[neighsync] Ignoring IPv4 link local addresses #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping over writing ipv4 link local neighbors to APPL_DB. This was causing link local neighbors to appear and led to long switchover times during mux state change. Tested in test_neighbor.py by adding a link local neighbor and making sure dbs do not contain the neighbor. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Ndancejic
force-pushed
the
neighsyncd_linklocal
branch
from
617954d to
938cf39
Compare
|
This pull request introduces 1 alert when merging 938cf39 into 4e53afc - view on LGTM.com new alerts:
|
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
prsunny
approved these changes
May 9, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
6 tasks
Ndancejic
added a commit
to Ndancejic/sonic-swss
that referenced
this pull request
Jun 10, 2022
* [neighsync] Ignoring IPv4 link local addresses Skipping over writing ipv4 link local neighbors to APPL_DB. This was causing link local neighbors to appear and led to long switchover times during mux state change. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
prsunny
pushed a commit
that referenced
this pull request
Jun 10, 2022
* [neighsync] Ignoring IPv4 link local addresses Skipping over writing ipv4 link local neighbors to APPL_DB. This was causing link local neighbors to appear and led to long switchover times during mux state change. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
* [neighsync] Ignoring IPv4 link local addresses Skipping over writing ipv4 link local neighbors to APPL_DB. This was causing link local neighbors to appear and led to long switchover times during mux state change. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
|
202012 branch PR merged: #2324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping over writing ipv4 link local neighbors to APPL_DB.
This was causing link local neighbors to appear and led to long
switchover times during mux state change.
Tested in test_neighbor.py by adding a link local neighbor and making
sure dbs do not contain the neighbor.
Signed-off-by: Nikola Dancejic ndancejic@microsoft.com