When Bridge port is deleted treat L2 call back event AGED as FLUSH #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port will be bulk flushed. When SAI sends the notification to orchagent, some Platforms like Broadcom, sends them as Aged event instead of FLUSH event. if the bridge port is already deleted, to clean up the stale entries, consider the age event as FLUSH event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When a L2 aged call back 'SAI_FDB_EVENT_AGED' is received after the underlying Bridgeport is deleted, then treat it as 'SAI_FDB_EVENT_FLUSHED'
Why I did it
For the scenario explained in the issue #2254 , the fix made does not handle it for the broadcom based platforms.
Broadcom based platforms, does not support "SAI_FDB_EVENT_FLUSHED" event and only "SAI_FDB_EVENT_AGED" is posted instead. Hence when a L2 call back routine is received as AGED event after the underlying bridge port is deleted, then to clean-up the internal cache . its treated as SAI_FDB_EVENT_FLUSHED.
How I verified it
In broadcom based platforms) create vlan say 100b) associate interface say Ethernet0 with vlan 100c) Learn about 100 dynamic macs on Ethernet0,vlan100d) remove Ethernet0, vlan100 membership) remove vlan 100
Without fix, step 'e' will fail , as the internal cache would not be deleted. With Fix, it will be deleted successfully from the Application DB.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Treat AGED event as FLUSH when bridge port is deleted for broadcom based platforms.