When a MAC moved from orphan port to MCLAG interface, the the MAC info goes out of sync between MCLAG peers #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AC not updated in one of the MCLAG peer. As a fix, when a LEARN event is recieved for a MCLAG advertized mac, it should be due to mac move. hence, the MAC entry is modified with the moved bridgeport as a dynamic FDB entry and the state DBs are updated accordingly. This will ensure that the peer node gets updated by the mac move event.
prasanna-cls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
when a LEARN event is received for a MC LAG advertised mac, it should be due to mac move.
Hence, the MAC entry is modified with the port and the state DBs are updated accordingly. This will ensure that the peer node gets updated by the mac move event.
Why I did it
On certain platforms like broadcom, the SAI FDB event SAI_FDB_EVENT_MOVE is not supported.
instead, SAI posts SAI_FDB_EVENT_AGED and SAI_FDB_EVENT_LEARN.
As part of the AGED event, the MLAG advertised macs are re-installed in hardware as it is not supposed to get aged as it was installed
with SAI_FDB_ENTRY_ATTR_ALLOW_MAC_MOVE and SAI_FDB_ENTRY_TYPE_STATIC..
Due to this there will be inconsistency in the remote and local state DB.
hence the peer node will never be intimated about the original mac movement to cause an issue.
How I verified it
a)MAC movement between orphan port to MC LAG interface, MAC is in sync in both peer devices
b)Learn 1K macs on MC LAG interface and shut down the MC LAG interface in one of the peer node, all macs must be pointing to ICCP link
c) dis-associate vlan and MC LAG interface, ICCP link after MAC learning, delete vlan
Which release branch to backport (provide reason below if selected)
Description for the changelog
MAC move from orphan port to MC LAG interface causes MAC entries to be out of sync among MC LAG peer devices.