-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[orchstats]: Add orch stats for orchagent profiling #2812
Draft
Pterosaur
wants to merge
7
commits into
sonic-net:master
Choose a base branch
from
Pterosaur:orchstats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
orchstats
branch
3 times, most recently
from
June 7, 2023 00:18
93f3852
to
3ede8b4
Compare
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
orchstats
branch
2 times, most recently
from
June 9, 2023 14:30
3b9a4bb
to
e0f839b
Compare
Signed-off-by: Ze Gan <ganze718@gmail.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
requested review from
neethajohn,
judyjoseph and
prsunny
as code owners
June 17, 2023 10:04
Pterosaur
changed the title
[orchstats]: Add orch stats
[orchstats]: Add orch stats for orchagent profiling
Jun 17, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add a new orchstats class and background thread for orchagent task statistics.
Why I did it
The original record, swss.rec, will take too much CPU and disk space in the scenario of a huge entry scale. So, a flyweight statistic method is needed for monitoring the performance of orchagent.
How I verified it
The SWSS Azp should pass and the PR: sonic-net/sonic-mgmt#8505 provides a script for profiling orchagent.
Details if related