Apply port speed again after disabling port AN #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem and Steps: Changing the port speed while port AN is enabled will not take effect after port AN is disabled. Current behavior/Root Cause: In PortsOrch, the port speed configuration will not be set to SAI when port AN is enabled. Solution: Apply port speed again after disabling port AN.
In PortsOrch, when autonegotiation is disabled for a port, this commit ensures that the port speed is updated correctly. If a new speed is configured while autonegotiation is disabled, the new speed is applied; otherwise, the current speed setting is reconfigured.
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Apply port speed again after disabling port AN.
In PortsOrch, when autonegotiation is disabled for a port, this PR ensures
that the port speed is updated correctly. If a new speed is configured while
autonegotiation is disabled, the new speed is applied; otherwise, the current
speed setting is reconfigured.
Why I did it
In PortsOrch, the port speed configuration will not be set to SAI when port AN is enabled.
Changing the port speed while port AN is enabled will not take effect after port AN is disabled.
In some chips, the port speed can not be modified when port AN is enabled.
How I verified it
Details if related