[muxorch] run updateroutes before disbling neighbor during update #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdb update from an active mux port to a standby mux port when a static route was present caused orchagent crash. This is because the route was still pointing to the active neighbor nexthop when disabling this neighbor. This calls updateNexthopRoutes before disabling standby neighbor (but after neighbor nh is updated in muxorch) to set the route nexthop to the tunnel route. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fdb update from an active mux port to a standby mux port when a static route was present caused orchagent crash. This is because the route was still pointing to the active neighbor nexthop when disabling this neighbor. This calls updateNexthopRoutes before disabling standby neighbor (but after neighbor nh is updated in muxorch) to set the route nexthop to the tunnel route.
What I did
call updateNextHopRoutes when adding standby neighbor
Why I did it
Mac move between an active and standby mux port while a route was present was causing orchagent crash because route was still pointing to active next hop.
How I verified it
added vstest to cover this scenario