[subnet decap] Add subnet decap rule based on overlay ECMP #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingwang-ms
reviewed
May 21, 2024
| @@ -2088,6 +2123,14 @@ void VNetRouteOrch::postRouteState(const string& vnet, IpPrefix& ipPrefix, NextH | |||
| removeRouteAdvertisement(prefix_to_use); | |||
| } | |||
| } | |||
| if (route_state == "active") | |||
There was a problem hiding this comment.
Should this code be in the if block at line#2115?
There was a problem hiding this comment.
The if block at LINE#2115 checks if the vnet is allowed to advertise prefix. The decap term should be added even if the vnet is not allowed to advertise prefix.
bingwang-ms
reviewed
May 21, 2024
orchagent/vnetorch.cpp
Outdated
| inline void VNetRouteOrch::removeSubnetDecapTerm(const IpPrefix &ipPrefix) | ||
| { | ||
| const SubnetDecapConfig &config = gTunneldecapOrch->getSubnetDecapConfig(); | ||
| if (!config.enable || subnet_decap_terms_created_.find(ipPrefix) == subnet_decap_terms_created_.end()) |
There was a problem hiding this comment.
Suggest not checking config.enable. Even if it's disabled, user should be able to remove it.
bingwang-ms
approved these changes
May 23, 2024
8 tasks
|
@lolyu , we need to ensure test_vnet_vxlan in sonic-mgmt passes and no stale decap entries present. Could you please confirm? |
…el route Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
force-pushed
the
subnet_decap_overlay_ecmp
branch
from
abc7e91 to
075af2f
Compare
prsunny
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support dynamic decap rule generation based on the Vxlan tunnel route of Overlay ECMP.
This depends on: #3117
Why I did it
To enable SONiC with the capability to decap IPinIP packets with dest IP in the Overlay ECMP Vxlan tunnel route prefix.
How I verified it
VS test:
Details if related