Make bulk SAI calls in order for non-OID objects in the bulker API #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mint570
force-pushed
the
bulker_order_upstream
branch
from
b6a1d65 to
0068129
Compare
Bug: 242672938 This changes has certain limitations, such as we cannot add and delete the same entry multiple times. http://fusion2/05d0fb67-6234-3703-ac25-80fd3da474ef Change-Id: I133f3836046460172609a07895ccd8c41c4e67cf
mint570
force-pushed
the
bulker_order_upstream
branch
from
0068129 to
28d9bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Today, the bulker library does not maintain order for non-OID objects. This PR changes it to keep the requested order.
Why I did it
As part of the performance improvement effort, we updated P4Orch route manager to use bulk SAI API. With the current bulker library, it does not maintain the order. For the SDN use case, keeping the route programming order is important (for example, the default route needs to be programmed first to avoid packet drop).
How I verified it
Unit test
Details if related
N/A