[intfsorch]: Add unit test with gtest #971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test cases for intfsorch.cpp * Also modify aclorch_ut.cpp according to the following changes * Move common extern declarations to mock_orchagent_main.h * Move consumer->addToSync() wrapper function to portal.h * Move SAI initialize/uninitialize functions to ut_helper
|
retest this please |
|
retest this please |
|
Please help rebase it to latest master, and I have some patch for you, which build the subdir, and test it during build process. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Add 'show' CLI for system-health feature Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com> * Add unit test for 'system-health' feature, add support for testing in 'show' script, Fix comments Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com> * Fix additional comments * Fix comments * Update Command-Reference.md Add a CLI reference for system-health feature. * Fix LGTM alerts * Fix comment Change 'Ignore' to 'Ignored' * Update Command-Reference.md Fix example output * Update Command-Reference.md * Change 'summary' output and adapt test and reference to the new change * Update main.py * Fix multiline output for expected output * keep output aligned * Fix import for unit testing after community change * Add clicommon for @cli.group after community change * Align changes in the feature to the CLI on commit sonic-net/sonic-buildimage@8ea2ab5 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Update main.py * Move new group CLI into a separate file * Organize imports per PEP8 standards * Organize imports per PEP8 standards * Reformat docstring for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add unit test for intfsorch with gtest
Why I did it
This is a follow-up work of adding unit test for sonic-swss after aclorch
How I verified it
Build and run the tests. Verified that all newly added test cases and influenced old test cases are passed.
Details if related
Add test cases in intfsorch_ut.cpp.
Also modify aclorch_ut.cpp according to the following changes: