Allow show ztp to display non-sensitive information visible to non-ro… #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot user Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
|
This pull request fixes 1 alert when merging 6e10421 into ea0205e - view on LGTM.com fixed alerts:
|
|
retest this please |
1 similar comment
|
retest this please |
shlomibitton
approved these changes
Nov 17, 2020
|
retest this please |
liat-grozovik
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow show ztp to display non-sensitive information visible to non-root user
Signed-off-by: Rajendra Dendukuri rajendra.dendukuri@broadcom.com
What I did
Removed user privileges checks. These changes fix [ZTP] "show ztp status" command requires root privileges to be executed sonic-buildimage#5377. Requires Create a shadow ZTP data json file accessible to non-root user sonic-ztp#21
How I did it
Removed root user check.
How to verify it
show ztp status
Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ show ztp status
Root privileges are required for this operation
New command output (if the output of a command-line utility has changed)
root@sonic:/usr/lib/ztp/tests# ztp status
ZTP Admin Mode : True
ZTP Service : Inactive
ZTP Status : SUCCESS
ZTP Source : dhcp-opt67
Runtime : 09s
Timestamp : 2020-10-14 03:15:20 UTC
ZTP Service is not running
0001-test-plugin: SUCCESS
root@sonic:/usr/lib/ztp/tests# exit
admin@sonic:~$ ztp status
ZTP Admin Mode : True
ZTP Service : Inactive
ZTP Status : SUCCESS
ZTP Source : dhcp-opt67
Runtime : 09s
Timestamp : 2020-10-14 03:15:20 UTC
ZTP Service is not running
0001-test-plugin: SUCCESS
admin@sonic:~$ show ztp status
ZTP Admin Mode : True
ZTP Service : Inactive
ZTP Status : SUCCESS
ZTP Source : dhcp-opt67
Runtime : 09s
Timestamp : 2020-10-14 03:15:20 UTC
ZTP Service is not running
0001-test-plugin: SUCCESS