[portconfig] Check supported speeds before setting port speed #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
|
@maksymbelei95 - are you going to promote this PR ? |
pshulik
previously approved these changes
Oct 18, 2021
* Checking whether requested speed is supported by the port by reading related field of PORT_TABLE:EthernetXX table in APPL_DB. If the field is absent or something went wrong while reading, then anyway set the speed to the port. Signed-off-by: Maksym Belei <Maksym_Belei@jabil.com>
pshulik
approved these changes
Oct 22, 2021
|
@dprital, Could please review or add additional reviewer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reading related field of PORT_TABLE:EthernetXX table in APPL_DB.
If the field is absent or something went wrong while reading,
then anyway set the speed to the port.
Signed-off-by: Maksym Belei Maksym_Belei@jabil.com
- What I did
Checking of supported speeds by the port has added. If the speed is unsupported,
porconfigscript will throw an exception and reject setting the speed to the port.- How I did it
By reading and comparing field
"supp_speed"of tablePORT_TABLE:EthernetXXof APPL_DB with requested value of speed.If there was something wrong during reading field
"supp_speed", the speed will be set without checking.- How to verify it
Execute command config interface speed with passing speed argument with value of unsupported speed.
- Previous command output (if the output of a command-line utility has changed)
Currently, command "sudo config interface speed" allows any value of speed parameter.
- New command output (if the output of a command-line utility has changed)
if to request to set some unsupported speed, portconfig script will throw an exception:
- Delails
Related PRs:
sonic-net/sonic-swss#1622
#1391