[sonic-package-manager] support sonic-cli-gen and packages with YANG model #1650

stepanblyschak · 2021-06-02T13:56:36Z

NOTE: DEPENDS ON #1644

What I did

This PR brings in support for packages with YANG models and CLI auto generation capabilities for 3rd party packages.

How I did it

Packages can set two new flags in manifest - "auto-generate-show" and "auto-generate-config" in addition to YANG module recorded in package image label "com.azure.sonic.yang-module".

How to verify it

Build and run. Prepare some package with YANG model and test CLI is generated for it.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

…packages-migration

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

…packages-migration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

…spm_warm

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com>

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

renukamanavalan · 2021-11-11T17:50:49Z

@praveen-li Could you please also review?

renukamanavalan

Looks good to me. Just added few minor comments only.
We could merge upon approval by @praveen-li

config/config_mgmt.py

sonic_package_manager/service_creator/creator.py

rlhui · 2021-11-16T06:38:36Z

@praveen-li , @renukamanavalan - do you approve this PR or anything pending? Thanks.

config/config_mgmt.py

sonic_package_manager/main.py

sonic_package_manager/service_creator/creator.py

…o spm-yang

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

lgtm-com · 2021-11-17T01:49:30Z

This pull request introduces 1 alert when merging bf05d42 into e7535ae - view on LGTM.com

new alerts:

1 for Insecure temporary file

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

renukamanavalan · 2021-11-17T16:03:21Z

@renukamanavalan - completed review -- good to merge
@praveen-li -- Waiting for Praveen's approval

renukamanavalan

Waiting for Praveen's approval

praveen-li

Thanks for explaining it to me in meeting. I specially reviewed changes in ConfigMgmt. LGTM overall.

praveen-li · 2021-11-24T01:37:10Z

config/config_mgmt.py

+        module_name = self.get_module_name(yang_module_str)
+        module_path = os.path.join(YANG_DIR, '{}.yang'.format(module_name))
+        if os.path.exists(module_path):
+            raise Exception('{} already exists'.format(module_name))


caller of add_module should be able to handle it gracefully.

The caller can catch the exception and handle it gracefully.

…model (#1650) - What I did This PR brings in support for packages with YANG models and CLI auto generation capabilities for 3rd party packages. - How I did it Packages can set two new flags in manifest - "auto-generate-show" and "auto-generate-config" in addition to YANG module recorded in package image label "com.azure.sonic.yang-module". - How to verify it Build and run. Prepare some package with YANG model and test CLI is generated for it. Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com> Co-authored-by: Vadym Hlushko <vadymh@nvidia.com>

…th YANG model (sonic-net#1650)" This reverts commit f5e5a56.

…th YANG model (#1650)" (#1972) This reverts commit f5e5a56.

…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" This reverts commit fe00bbf.

…th YANG model (#1650)" (#1972) This reverts commit f5e5a56.

…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" This reverts commit fe00bbf.

…kages with YANG model (#1650)" (#1972)" (#1994) This reverts commit fe00bbf. - What I did Revert previous revert, since the proposed fix has been merged - sonic-net/sonic-buildimage#9587 - How I did it Revert the revert. - How to verify it Run build an on the switch.

…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" (sonic-net#1994) This reverts commit fe00bbf. - What I did Revert previous revert, since the proposed fix has been merged - sonic-net/sonic-buildimage#9587 - How I did it Revert the revert. - How to verify it Run build an on the switch.

stepanblyschak and others added 30 commits November 3, 2020 15:56

[sonic-installer] migrate SONiC packages

2356869

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

fix temp dir path for chroot

ece3845

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

fix for install of already installed image

8bc75a7

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

move constants to the top

e72f540

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

Merge branch 'master' of github.com:azure/sonic-utilities into sonic-…

1a6d5d9

…packages-migration

[sonic_installer] migrate packages from old docker library

be4f089

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

Merge branch 'master' of github.com:azure/sonic-utilities into sonic-…

2240308

…packages-migration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

remove unused imports

9fd283d

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix redefining path

0cbaa3e

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

[sonic-package-manager] add new utility to manage SONiC packages

1a99797

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'sonic-packages-migration' into spm

a80ecb0

add help for some options

06dfd30

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

add command line reference for sonic-package-manager

725210d

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix upgrade command missing argument

f2ee39f

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

warm-reboot support for sonic packages

7bf937e

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

iteritems -> items

c724569

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'spm' into spm_warm

ac011a3

fix issue in metadata dict generation

3dc793f

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'spm' of github.com:stepanblyschak/sonic-utilities into …

4e4a9ea

…spm_warm

fix creator with service name

ea14867

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

default value for component constraint

faeadcf

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Merge branch 'spm' into spm_warm

cd7d387

fix passing installed_packages

31138d0

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Update doc/Command-Reference.md

ae1ce45

Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com>

use defaultdict

5c045e0

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix internal review comments

a1a97f9

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

fix internal review comments

7a6c8d1

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

use get_installed_packages_list() function

c4b4225

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

dont fail uninstall when no package in installed list

f32d038

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

drop support for monit as monit is getting deprecated

83f2af6

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

stepanblyschak mentioned this pull request Nov 10, 2021

[sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool #1644

Merged

renukamanavalan reviewed Nov 11, 2021

View reviewed changes

config/config_mgmt.py Show resolved Hide resolved

sonic_package_manager/service_creator/creator.py Show resolved Hide resolved

liat-grozovik mentioned this pull request Nov 14, 2021

Event and Alarm Framework HLD sonic-net/SONiC#761

Closed

renukamanavalan reviewed Nov 16, 2021

View reviewed changes

config/config_mgmt.py Show resolved Hide resolved

config/config_mgmt.py Outdated Show resolved Hide resolved

sonic_package_manager/main.py Show resolved Hide resolved

sonic_package_manager/service_creator/creator.py Show resolved Hide resolved

zhangyanzhao added the Request for 202111 Branch label Nov 16, 2021

stepanblyschak added 2 commits November 17, 2021 03:19

Merge branch 'master' of https://github.com/Azure/sonic-utilities int…

eb57015

…o spm-yang

handle review comments

bf05d42

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

fix LGTM warning

d0a2ff7

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>

renukamanavalan approved these changes Nov 20, 2021

View reviewed changes

praveen-li approved these changes Nov 24, 2021

View reviewed changes

liat-grozovik merged commit f5e5a56 into sonic-net:master Nov 24, 2021

aravindmani-1 mentioned this pull request Dec 8, 2021

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#9467

Closed

5 tasks

DavidZagury mentioned this pull request Dec 8, 2021

[Submodule][sonic-utilities] Update sonic-utilities submodule sonic-net/sonic-buildimage#9469

Closed

5 tasks

prgeor added a commit to prgeor/sonic-utilities that referenced this pull request Dec 16, 2021

Revert "[sonic-package-manager] support sonic-cli-gen and packages wi…

747ef83

…th YANG model (sonic-net#1650)" This reverts commit f5e5a56.

prgeor mentioned this pull request Dec 16, 2021

Revert "[sonic-package-manager] support sonic-cli-gen and packages wi… #1972

Merged

prgeor added a commit that referenced this pull request Dec 17, 2021

Revert "[sonic-package-manager] support sonic-cli-gen and packages wi…

fe00bbf

…th YANG model (#1650)" (#1972) This reverts commit f5e5a56.

stepanblyschak mentioned this pull request Dec 20, 2021

[init_cfg.json][YANG] The initial configuration /etc/sonic/init_cfg.json does not pass YANG validation sonic-net/sonic-buildimage#9598

Open

stepanblyschak added a commit to stepanblyschak/sonic-utilities that referenced this pull request Dec 30, 2021

Revert "Revert "[sonic-package-manager] support sonic-cli-gen and pac…

ffdf73a

…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" This reverts commit fe00bbf.

stepanblyschak mentioned this pull request Dec 30, 2021

Revert "Revert "[sonic-package-manager] support sonic-cli-gen and pac… #1994

Merged

judyjoseph pushed a commit that referenced this pull request Jan 5, 2022

Revert "[sonic-package-manager] support sonic-cli-gen and packages wi…

c48c363

…th YANG model (#1650)" (#1972) This reverts commit f5e5a56.

judyjoseph added the Included in 202111 Branch label Jan 9, 2022

DavidZagury added a commit to DavidZagury/sonic-utilities that referenced this pull request Jan 12, 2022

Revert "Revert "[sonic-package-manager] support sonic-cli-gen and pac…

d0ebe63

…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" This reverts commit fe00bbf.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sonic-package-manager] support sonic-cli-gen and packages with YANG model #1650

[sonic-package-manager] support sonic-cli-gen and packages with YANG model #1650

stepanblyschak commented Jun 2, 2021 •

edited by liat-grozovik

Loading

renukamanavalan commented Nov 11, 2021

renukamanavalan left a comment

rlhui commented Nov 16, 2021

lgtm-com bot commented Nov 17, 2021

renukamanavalan commented Nov 17, 2021

renukamanavalan left a comment

praveen-li left a comment

praveen-li Nov 24, 2021

stepanblyschak Nov 24, 2021

[sonic-package-manager] support sonic-cli-gen and packages with YANG model #1650

[sonic-package-manager] support sonic-cli-gen and packages with YANG model #1650

Conversation

stepanblyschak commented Jun 2, 2021 • edited by liat-grozovik Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

renukamanavalan commented Nov 11, 2021

renukamanavalan left a comment

Choose a reason for hiding this comment

rlhui commented Nov 16, 2021

lgtm-com bot commented Nov 17, 2021

renukamanavalan commented Nov 17, 2021

renukamanavalan left a comment

Choose a reason for hiding this comment

praveen-li left a comment

Choose a reason for hiding this comment

praveen-li Nov 24, 2021

Choose a reason for hiding this comment

stepanblyschak Nov 24, 2021

Choose a reason for hiding this comment

stepanblyschak commented Jun 2, 2021 •

edited by liat-grozovik

Loading