[show] Fix command "show nat translations count" #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- What I did Add the optin parameter "verbose" for "show nat translations count". - Why I did it This command cannot be executed because the necessary variable "verbose" is missing. - How I verified it Verify the command could be executed successfully ``` admin@sonic:~$ show nat translations count Static NAT Entries ..................... 0 Static NAPT Entries ..................... 0 Dynamic NAT Entries ..................... 0 Dynamic NAPT Entries ..................... 0 Static Twice NAT Entries ..................... 0 Static Twice NAPT Entries ..................... 0 Dynamic Twice NAT Entries ..................... 0 Dynamic Twice NAPT Entries ..................... 0 Total SNAT/SNAPT Entries ..................... 0 Total DNAT/DNAPT Entries ..................... 0 Total Entries ..................... 0 admin@sonic:~$ show nat translations count --verbose Running command: sudo natshow -c Static NAT Entries ..................... 0 Static NAPT Entries ..................... 0 Dynamic NAT Entries ..................... 0 Dynamic NAPT Entries ..................... 0 Static Twice NAT Entries ..................... 0 Static Twice NAPT Entries ..................... 0 Dynamic Twice NAT Entries ..................... 0 Dynamic Twice NAPT Entries ..................... 0 Total SNAT/SNAPT Entries ..................... 0 Total DNAT/DNAPT Entries ..................... 0 Total Entries ..................... 0 admin@sonic:~$ ```
|
can you add unit test? |
|
Add the unit test for show nat |
|
Hi @lguohan, could you help to review the change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the optin parameter "verbose" for "show nat translations count".
How I did it
This command cannot be executed because the necessary variable "verbose" is missing.
How to verify it
Verify the command could be executed successfully.
New command output (if the output of a command-line utility has changed)