sonic-utilities: CLICK support added to restart certain services after config load #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Certain features (like NTP,SNMP) requires restarting of the related services after doing config load. Added Unit Test cases corresponding to the config load command * Added the common capability to restart services after doing config load. Signed-off-by: Saravanan I <saravan@celestica.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain features (like NTP,SNMP) requires restarting of the related services after doing config load.
Signed-off-by: Saravanan I saravan@celestica.com
What I did
Certain features (like NTP,SNMP) requires restarting of the related services after doing config load. After doing config load, some of the features (like ntp,snmp) doesn't work. Only after doing explicit restarting of services, this features work. Added the common capability to restart services in background after doing config load.
How I did it
Restart the services (SNMP,NTP) in the background when user executes the config load (click command) when the SNMP/NTP related configuration found in config_db json file. Otherwise those services will not be restarted.
How to verify it
Have NTP,SNMP configurations in a config_db.json file. Load the configuration file using config load CLI. Verify that NTP,SNMP features work seamless without requiring any explicit reload of the related services. - PASS
Which release branch to backport (provide reason below if selected)