Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SAG implementation #2881

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add SAG implementation #2881

wants to merge 14 commits into from

Conversation

superchild
Copy link

What I did

How I did it

  • Add new commands
    • config static-anycast-gateway mac_address add/del
    • config vlan static-anycast-gateway add/del
  • Add unit test cases

How to verify it

  • Executing unit tests

Signed-off-by: Jimi Chen jimi_chen@edge-core.com

@superchild superchild mentioned this pull request Jun 16, 2023
Merged
@superchild superchild marked this pull request as ready for review June 19, 2023 03:53
superchild
superchild commented Jun 19, 2023
View reviewed changes
config/main.py

@mac_address.command('del')
@clicommon.pass_db
def del_mac(db):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junchao-Mellanox
The argument is removed.

@superchild superchild mentioned this pull request Jun 19, 2023
Closed
@superchild
Copy link
Author

@zhangyanzhao ,
Sorry for the wrong operation on the original #1887.
I created a new one and updated the review comments in the new PR, need your help to assign the reviewers.

@Junchao-Mellanox
For the original comment on #1887, I try to comment to change on this new PR and also reply in the original PR.
Please help to check if anything lost.

@maipbui
Copy link
Contributor

maipbui commented Jun 29, 2023 •
edited
Loading

@superchild Please merge latest master code to trigger Semgrep.

@superchild
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@superchild can you please handle conflicts so we can go a head and merge?

@superchild
Copy link
Author

@liat-grozovik
I don't work on this project anymore and no related build machine for me to test now.
I'll suggest someone can help to finish this, or send the other PR.

@yanjundeng yanjundeng mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junchao-Mellanox Junchao-Mellanox Junchao-Mellanox approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@superchild @maipbui @mssonicbld @liat-grozovik @Junchao-Mellanox