-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config, show] Add CLI commands for Path Tracing Midpoint #2983
base: master
Are you sure you want to change the base?
Conversation
f0f3c31
to
2d58d93
Compare
2d58d93
to
ab465ec
Compare
@prsunny @kperumalbfn could you please help and review the code of this PR? |
scripts/intfutil
Outdated
self.front_panel_ports_list = get_frontpanel_port_list(self.config_db) | ||
self.appl_db_keys = appl_db_keys_get(self.db, self.front_panel_ports_list, None) | ||
self.get_raw_po_int_configdb_info = get_raw_portchannel_info(self.config_db) | ||
self.portchannel_list = get_portchannel_list(self.get_raw_po_int_configdb_info) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why port-channel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kperumalbfn The port channel list was defined but never used, now I removed it.
@kperumalbfn Many thanks for the review. All comments have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @lguohan @qiluo-msft This PR has been reviewed and approved. It is ready for merge. Could you please merge the PR? |
@kperumalbfn Could you please advice who should merge the code? |
@cscarpitta , there are conflict, can you rebase? |
00e17a0
to
6d0076e
Compare
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
6d0076e
to
c302d4b
Compare
@qiluo-msft can you please help to check and merge this code PR? Thanks. |
The orchagent extension PR to support Path Tracing has been merged: sonic-net/sonic-swss#2903 Can you please take a look and help merge this PR as well? |
This PR has been pending merge for some time now. Could we merge this as part of 202411? The HLD (Oct 2023) and Orchagent (May 24) has been merged. |
What I did
Extended the SONiC CLI to configure Path Tracing Midpoint.
HLD: sonic-net/SONiC#1456
How I did it
config interface
command by introducing a new subcommandpath-tracing
that allows users to configure the Interface ID and Timestamp Template parameters required for the PT Midpoint functionality.show interfaces
command by introducing a new subcommandpath-tracing
that allows users to verify the current PT Midpoint configuration (i.e., the Interface ID and Timestamp Template).How to verify it
Unit tests: