Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config, show] Add CLI commands for Path Tracing Midpoint #2983

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cscarpitta
Copy link

@cscarpitta cscarpitta commented Sep 15, 2023

What I did

Extended the SONiC CLI to configure Path Tracing Midpoint.
HLD: sonic-net/SONiC#1456

How I did it

  • Extended the existing config interface command by introducing a new subcommand path-tracing that allows users to configure the Interface ID and Timestamp Template parameters required for the PT Midpoint functionality.
  • Extended the existing show interfaces command by introducing a new subcommand path-tracing that allows users to verify the current PT Midpoint configuration (i.e., the Interface ID and Timestamp Template).

How to verify it

Unit tests:

  • tests/config_int_path_tracing_test.py
  • tests/intfutil_test.py

@cscarpitta cscarpitta force-pushed the srv6_pt_midpoint branch 4 times, most recently from f0f3c31 to 2d58d93 Compare September 30, 2023 15:54
@cscarpitta cscarpitta changed the title Add CLI commands for SRv6 Path Tracing [config, show] Add CLI commands for Path Tracing Midpoint Oct 12, 2023
@ahsalam
Copy link

ahsalam commented Oct 14, 2023

@prsunny @kperumalbfn could you please help and review the code of this PR?
This feature is tracked for 202311 release and documented by this HLD sonic-net/SONiC#1456
@zhangyanzhao

scripts/intfutil Outdated
self.front_panel_ports_list = get_frontpanel_port_list(self.config_db)
self.appl_db_keys = appl_db_keys_get(self.db, self.front_panel_ports_list, None)
self.get_raw_po_int_configdb_info = get_raw_portchannel_info(self.config_db)
self.portchannel_list = get_portchannel_list(self.get_raw_po_int_configdb_info)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why port-channel?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn The port channel list was defined but never used, now I removed it.

@cscarpitta
Copy link
Author

@kperumalbfn Many thanks for the review. All comments have been addressed.

kperumalbfn
kperumalbfn previously approved these changes Nov 16, 2023
Copy link
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cscarpitta
Copy link
Author

Hi @lguohan @qiluo-msft This PR has been reviewed and approved. It is ready for merge. Could you please merge the PR?

@cscarpitta
Copy link
Author

@kperumalbfn Could you please advice who should merge the code?

@lguohan
Copy link
Contributor

lguohan commented May 15, 2024

@cscarpitta , there are conflict, can you rebase?

@cscarpitta cscarpitta force-pushed the srv6_pt_midpoint branch 2 times, most recently from 00e17a0 to 6d0076e Compare May 15, 2024 20:05
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
@zhangyanzhao
Copy link
Collaborator

@qiluo-msft can you please help to check and merge this code PR? Thanks.

@cscarpitta
Copy link
Author

@qiluo-msft @lguohan

The orchagent extension PR to support Path Tracing has been merged: sonic-net/sonic-swss#2903

Can you please take a look and help merge this PR as well?

@ahsalam
Copy link

ahsalam commented Aug 8, 2024

@qiluo-msft, @zhangyanzhao,

This PR has been pending merge for some time now. Could we merge this as part of 202411?

The HLD (Oct 2023) and Orchagent (May 24) has been merged.
HLD: sonic-net/SONiC#1456
Orchagent: sonic-net/sonic-swss#2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants