[config]: Add file check before load_minigraph command #306
Conversation
|
yes. I think the use-case for load_minigraph is that the config_db.json file is not easy to modify while right now the minigraph is the source of the 'original configuration' for the switch. |
config/main.py
Outdated
| @@ -321,7 +321,11 @@ def load_mgmt_config(filename): | |||
| expose_value=False, prompt='Reload config from minigraph?') | |||
| def load_minigraph(): | |||
| """Reconfigure based on minigraph.""" | |||
| #Stop services before config push | |||
| # Check /etc/sonic/minigraph.xml file exists | |||
| if not os.path.isfile('/etc/sonic/minigraph.xml'): | |||
There was a problem hiding this comment.
/etc/sonic/minigraph.xml [](start = 27, length = 24)
/etc/sonic/minigraph.xml [](start = 27, length = 24)
should not be hardcoded. #Closed
Since 'qos' is a local function, why we don't directly call it? Refers to: config/main.py:344 in ef57bac. [](commit_id = ef57bac77bcdbf0e04b0d2b0295484ee524b2331, deletion_comment = False) |
This will prevent config load_minigraph fail during the middle of the command execution. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
| @@ -321,7 +322,11 @@ def load_mgmt_config(filename): | |||
| expose_value=False, prompt='Reload config from minigraph?') | |||
| def load_minigraph(): | |||
| """Reconfigure based on minigraph.""" | |||
| #Stop services before config push | |||
| # Check /etc/sonic/minigraph.xml file exists | |||
| if not os.path.isfile(SONIC_MINIGRAPH_PATH): | |||
There was a problem hiding this comment.
if not os.path.isfile(SONIC_MINIGRAPH_PATH): [](start = 4, length = 44)
I suggest test it by command sonic-cfggen -m
The absolute path is internal knowledge of cfggen.
There was a problem hiding this comment.
Agree here, sonic-cfggen might even do some sanity check here.
…nic-net#306) * update the return for update_firmware api's failure case when the image file doesn't exist * update comments * update comment * update comment
This will prevent config load_minigraph fail during the
middle of the command execution.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com