Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Only register mclag, not its subcommands #3088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebageek
Copy link

What I did

Only mclag needs to be registered with the config utility. Registering the mclag subcommands results in "config members" and "config unique-ip" becoming valid subcommands, without the added "mclag". Having them as "config mclag members" and "config members unique-ip" is sufficient.

How I did it

Removed the command registration for mclag.mclag_member and mclag.mclag_unique_ip

How to verify it

Search for member or unique-ip in config --help and check if they're gone.

Previous command output (if the output of a command-line utility has changed)

# config |grep -e member -e unique-ip
  member
  unique-ip                 Configure Unique IP on MCLAG Vlan interface

New command output (if the output of a command-line utility has changed)

# config |grep -e member -e unique-ip
#

Copy link

linux-foundation-easycla bot commented Dec 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sebageek / name: Sebastian Lohff (f9735cf)

Only mclag needs to be registered with the config utility. Registering
the mclag subcommands results in "config members" and "config unique-ip"
becoming valid subcommands, without the added "mclag". Having them as
"config mclag members" and "config members unique-ip" is sufficient.

Signed-off-by: Sebastian Lohff <sebastian.lohff@sap.com>
@sebageek sebageek force-pushed the sebageek/only-register-mclag-main-command-not-subcommands branch from 27514b7 to f9735cf Compare December 18, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant