Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the rules of the deleted table - fix bug #3161

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shiraez
Copy link

@shiraez shiraez commented Feb 11, 2024

What I did

Fix bug for #2550:
Delete the rules of the deleted table

How I did it

Add a call to acl-loader delete

How to verify it

config load acl.json

{
    "ACL_TABLE": 
    {
        "L3_IPV4_INGRESS": 
         { 
               "type": "L3", "stage": "INGRESS", "ports": ["Ethernet127"], "policy_desc": "L3_IPV4_INGRESS" 
          }
    },
    "ACL_RULE":  
     {
          "L3_IPV4_INGRESS|rule1": 
           { 
                   "PACKET_ACTION": "FORWARD", "SRC_IP": "1.1.1.1/32", "DST_IP": "2.2.2.2/32", "L4_SRC_PORT": 43, "L4_DST_PORT_RANGE": "10-20", "DSCP":62, "IP_PROTOCOL": 6, "PRIORITY": 1000 
           }
    }
}

show acl rule
config acl remove rule

Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo show acl rule
Table            Rule    Priority    Action    Match                     Status
---------------  ------  ----------  --------  ------------------------  --------
L3_IPV4_INGRESS  rule1   1000        FORWARD   DSCP: 62                  Inactive
                                               DST_IP: 2.2.2.2/32
                                               IP_PROTOCOL: 6
                                               L4_DST_PORT_RANGE: 10-20
                                               L4_SRC_PORT: 43
                                               SRC_IP: 1.1.1.1/32

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo show acl rule
Table            Rule    Priority    Action    Match                     Status
---------------  ------  ----------  --------  ------------------------  --------

Copy link

linux-foundation-easycla bot commented Feb 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@shiraez shiraez changed the title Remove rule of the deleted table - fix bug Remove the rules of the deleted table - fix bug Feb 12, 2024
@shiraez
Copy link
Author

shiraez commented Feb 18, 2024

@ArthiGovindaraj This will fix your bug.

@shiraez
Copy link
Author

shiraez commented Feb 19, 2024

@stcheng would you be able to review?

@shiraez
Copy link
Author

shiraez commented Mar 26, 2024

@qiluo-msft , could you please help review it? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant