SONIC CLI for CLI-Sessions feature #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 18, 2024
config/main.py
Outdated
|
|
||
| @ssh.command('max-sessions') | ||
| @click.argument('max-sessions', metavar='<max-sessions>', required=True, | ||
| type=click.IntRange(0,100)) |
There was a problem hiding this comment.
@isabelmsft Please help check parameter validation logic.
There was a problem hiding this comment.
@qiluo-msft upper limit for this config is specified in HLD and in yang models, please take a look:
https://github.com/sonic-net/sonic-buildimage/pull/17623/files#diff-7202f7348dad4b5be36f441f7ff0a5d6468395cbf89a9b75aa87399cef07292dR2598
qiluo-msft
previously approved these changes
May 13, 2024
|
Please resolve conflicts. #Closed |
i-davydenko
force-pushed
the
dev-cli-sessions
branch
from
a5f9308 to
103f903
Compare
i-davydenko
force-pushed
the
dev-cli-sessions
branch
12 times, most recently
from
b4572f1 to
209438b
Compare
i-davydenko
force-pushed
the
dev-cli-sessions
branch
from
209438b to
9eda124
Compare
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft , you approved all the rest. Could you please approve that one? |
qiluo-msft
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#1367
What I did
Implement next commands for CLI-sessions feature:
config serial-console inactivity-timeout
config serial-console sysrq-capabilities
show serial-console
config ssh max-sessions
config ssh inactivity-timeout
show ssh
How I did it
Write handlers in config/main.py for serial-console and ssh commands to cover configuration set;
Write handlers in show/main.py for serial-console and ssh to cover show commands.
How to verify it
Manual tests
Previous command output (if the output of a command-line utility has changed)
n/a
New command output (if the output of a command-line utility has changed)
n/a