Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System ready] Extend sysmonitor functionality to wait for host daemons #3294

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fastiuk
Copy link
Contributor

@fastiuk fastiuk commented Apr 28, 2024

depends-on: sonic-net/sonic-buildimage#18817

What I did

To extend sysmonitor to report services states according to HLD: sonic-net/SONiC#1363

How I did it

  • A new "irrel_for_sysready" configuration was added to "FEATURE" table to handle services for which sysmonitor shouldn't wait for.

How to verify it

  • Start NOS on the box
  • Make sure it defines system ready status
  • Make sure sysreadyshow shows all services as OK

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@liat-grozovik
Copy link
Collaborator

@fastiuk please add PR description so this PR can be reviewed/merged

fastiuk added 2 commits May 16, 2024 03:36
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
@fastiuk fastiuk force-pushed the dev-sysready-extension branch from 6373b1b to f399b12 Compare May 16, 2024 00:36
@fastiuk fastiuk requested review from qiluo-msft and prgeor May 20, 2024 20:39
@fastiuk
Copy link
Contributor Author

fastiuk commented Aug 14, 2024

@prgeor can we get an approval on that?

@fastiuk
Copy link
Contributor Author

fastiuk commented Nov 4, 2024

@prgeor can we get an approval on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants