[Mellanox] Improve the prompt of the Mellanox sdk sniffer command. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompt the risk of excessive consumption of disk space when user intends to turn on the sdk sniffer. The SDK sniffer is a diagnosis feature, introduced with a view to recording the all the operations to SDK into the sniffer file which the low level team can replay and investigate. Only the sniffer file contains all the operations from SWSS restart does it help. To handle it in a way like log-rotate can hurt its integrity since the operations can be lost during rotating and to address this requires big effort. So we just add a promot of that risk for now.
|
|
|
please help to redo vstest. |
|
retest this please |
adjust prompt in order to make it more clear.
|
re-vstest, please. |
|
retest this please |
4 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
keboliu
approved these changes
Jun 10, 2019
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
liat-grozovik
approved these changes
Jun 25, 2019
qiluo-msft
approved these changes
Jun 25, 2019
|
retest this please |
added 2 commits
July 2, 2019 09:42
adjust prompt in order to make it more clear. (recommit this in order to trigger vstest of the sonic-utilities and check whether it can pass)
…sonic-utilities into warn-when-sdk-sniffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Prompt the risk of excessive consumption of disk space when user intends to turn on the sdk sniffer.
The SDK sniffer is a diagnosis feature, introduced with a view to recording all the operations to SDK into the sniffer file which the low-level team can replay and investigate. Only the sniffer file contains all the operations from SWSS restart does it help. To handle it in a way like log-rotate to limit its size can hurt its integrity since the operating records can be lost during rotating and to address this requires a big effort.
So we just add a prompt of that risk for now.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
Signed-off-by: Stephen Sun stephens@mellanox.com