[ZTP] Improvements to the connectivity-check plugin #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liorghub Can you please review? |
dgsudharsan
suggested changes
Sep 29, 2022
| @@ -61,30 +61,48 @@ class ConnectivityCheck: | |||
| iter_list = list(_host_list) | |||
| # Loop through current host list | |||
| for host in iter_list: | |||
| if interface is not None and not isString(interface): | |||
There was a problem hiding this comment.
Is this check required? The interface is parsed as string in line 130 and cannot be other type right?
There was a problem hiding this comment.
Agreed. Removed this redundant check.
liorghub
reviewed
Oct 6, 2022
| else: | ||
| # Discard invalid hosts | ||
| _host_list.remove(host) | ||
|
|
||
| if len(_host_list) == 0: | ||
| break | ||
|
|
||
| if dhcp: | ||
| logger.info('Restarting networking to establish connectivity') |
There was a problem hiding this comment.
Consider change to "Restarting networking service to kickstart DHCP".
- The user can now specify arguments that can be passed on to ping command when performing the connectivity check. The "args" field in the configuration section of the ztp.json needs to be specified. - The user can choose to restart dhcp if connectivity check fails in its first attempt. This is useful when the switch has rebooted and all the in-band interfaces are not yet active. Use "dhcp" : true in the configuration section of the ztp.json. - Added unit test cases
rajendra-dendukuri
force-pushed
the
connectivity_plugin
branch
from
6fdec8d to
2fdc1f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user can now specify arguments that can be passed on to ping command when performing the connectivity check. The "args" field in the configuration section of the ztp.json needs to be specified.
The user can choose to restart dhcp if connectivity check fails in its first attempt. This is useful when the switch has rebooted and all the in-band interfaces are not yet active. Use "dhcp" : true in the configuration section of the ztp.json.
Added unit test cases