Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVPN-VxLAN Multihoming HLD #1638

Closed

Conversation

mikemallin
Copy link

This HLD introduces support for EVPN-VXLAN Multihoming on SONiC.

Copy link

linux-foundation-easycla bot commented Mar 18, 2024

CLA Missing ID CLA Not Signed

@Yuval-Mellanox
Copy link
Contributor

Yuval-Mellanox commented Mar 21, 2024

@mikemallin is this proposal based on the previous community proposals for MH
(#1412) Marvell
(#1622) Broadcom
or is it a fresh new one?
@zhangyanzhao we should converge into one proposal

@Yuval-Mellanox Yuval-Mellanox requested review from marian-pritsak and removed request for marian-pritsak March 21, 2024 08:00
@adyeung
Copy link
Collaborator

adyeung commented Mar 21, 2024

@Yuval-Mellanox @zhangyanzhao the EVPN MH proposals from Cisco and BRCM are under active review in the Routing WG, the eventual goal is to reach a converged solution for the extended community, I haven't seen a HLD from #1412 yet, but if any org or individual is interested in contributing to EVPN MH, please reachout to the Routing WG sonic-wg-routing@lists.sonicfoundation.dev

@mikemallin
Copy link
Author

@mikemallin is this proposal based on the previous community proposals for MH (#1412) Marvell (#1622) Broadcom or is it a fresh new one? @zhangyanzhao we should converge into one proposal

This is the proposal that has been presented by Cisco at the Routing WG a few weeks ago.

Copy link

@AntonButenkoGL AntonButenkoGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

We have a small team of engineer working on the EVPN Multihoming implementation and decided to start from this PR as requirements base.

Can you, please, look at the questions we have regarding the requirements?


```
"ETHERNET_SEGMENT_TABLE:PortChannel01": {
"interface" = "PortChannel01"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the same "PortChannel01" in the table name as "interface" field?

<a id="313-sai-overview"></a>
### 3.1.3 SAI Overview

Add a new attribute "SAI_BRIDGE_PORT_ATTR_DF_BLOCK" in sai_bridge_port_attr_t to indicate that the bridge port is blocked to forward any BUM traffic received from the Tunnel.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as I understand - we support only VLAN-VNI mapping and not the bridging between vxlan interface and some physical port.
If this is true - we don't need this requirement, right?

@mikemallin
Copy link
Author

Hello,

We have a small team of engineer working on the EVPN Multihoming implementation and decided to start from this PR as requirements base.

Can you, please, look at the questions we have regarding the requirements?

Hello! I'd suggest waiting for now as a new, combined HLD is underway.

@adyeung
Copy link
Collaborator

adyeung commented Jun 26, 2024

Converged HLD posted as #1702, closing this PR

@adyeung adyeung closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants