Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLD for Golden config CLI support in multi-asic #1684

Merged
merged 1 commit into from
Jun 25, 2024
Merged

HLD for Golden config CLI support in multi-asic #1684

merged 1 commit into from
Jun 25, 2024

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Apr 28, 2024 •
edited
Loading

@wen587 wen587 marked this pull request as ready for review April 28, 2024 05:48
@wen587 wen587 requested a review from qiluo-msft April 28, 2024 05:48
@wen587 wen587 mentioned this pull request Apr 28, 2024
Merged
qiluo-msft pushed a commit to sonic-net/sonic-utilities that referenced this pull request May 17, 2024
@wen587
[config]Improve config save cli to save to one file for multiasic (#3288
556026c 
)

HLD design : sonic-net/SONiC#1684

#### What I did
Add support for config save to one file for multi-aisc.
#### How I did it
Extend support for one file save for multiasic using the below format:
```
{
  "localhost": {/*host config*/},
  "asic0": {/*asic0 config*/},
  ...
  "asicN": {/*asicN config*/}
}
```
#### How to verify it
Unit test and manual test on multiasic platform.
Example running multi:
```
admin@str2-8800-sup-2:~$ sudo config save -y tmp.json
Integrate each ASIC's config into a single JSON file tmp.json.
admin@str2-8800-sup-2:~$ cat tmp.json |more
{
    "localhost": {
        "ACL_TABLE": {
            "NTP_ACL": {
                "policy_desc": "NTP_ACL",
                "services": [
                    "NTP"
...
    "asic0": {
        "AUTO_TECHSUPPORT": {
            "GLOBAL": {
                "available_mem_threshold": "10.0",
```
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
@wen587 @arfeigin
[config]Improve config save cli to save to one file for multiasic (so…
12add72 
…nic-net#3288)

HLD design : sonic-net/SONiC#1684

#### What I did
Add support for config save to one file for multi-aisc.
#### How I did it
Extend support for one file save for multiasic using the below format:
```
{
  "localhost": {/*host config*/},
  "asic0": {/*asic0 config*/},
  ...
  "asicN": {/*asicN config*/}
}
```
#### How to verify it
Unit test and manual test on multiasic platform.
Example running multi:
```
admin@str2-8800-sup-2:~$ sudo config save -y tmp.json
Integrate each ASIC's config into a single JSON file tmp.json.
admin@str2-8800-sup-2:~$ cat tmp.json |more
{
    "localhost": {
        "ACL_TABLE": {
            "NTP_ACL": {
                "policy_desc": "NTP_ACL",
                "services": [
                    "NTP"
...
    "asic0": {
        "AUTO_TECHSUPPORT": {
            "GLOBAL": {
                "available_mem_threshold": "10.0",
```
@wen587 wen587 requested review from ganglyu and xincunli-sonic June 25, 2024 02:50
@wen587 wen587 merged commit 80b8d45 into sonic-net:master Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xincunli-sonic xincunli-sonic xincunli-sonic approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@ganglyu ganglyu Awaiting requested review from ganglyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wen587 @xincunli-sonic