Add SONiC secure boot test plan #662
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staphylo
reviewed
Aug 20, 2020
|
|
||
| **Steps:** | ||
| * Add a new config file in the allowlist | ||
| * Rebuild the image and install the image |
There was a problem hiding this comment.
Rebuild a signed image and install it
I feel emphasizing on the fact that the build needs to sign the image can be meaningful.
| **Steps:** | ||
| * Basic boot up test | ||
| * Allowlist not cover this scenario. | ||
| * Check /proc/cmdline |
There was a problem hiding this comment.
Check for secure_boot_enable=y in /proc/cmdline
This might be a bit more precise as to what needs to be checked for.
| ### 8. Test tempered image | ||
|
|
||
| **Steps:** | ||
| * Change a new file into the signed image |
There was a problem hiding this comment.
Maybe add (or flip a bit in the image)
| * Expect the reboot will be failed | ||
|
|
||
| ### 9. Test no executable files in rw folder after reboot | ||
| If there are any files with -x option in rw folder, the option will be removed after the SONiC switch reboot. |
There was a problem hiding this comment.
Maybe replace -x by +x ?
chmod syntax relies on + to add a flag and - to remove it.
Even though what you meant is completely understandable it might be more accurate to use +.
There was a problem hiding this comment.
yxieca
force-pushed
the
master
branch
2 times, most recently
from
8498931 to
8837dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.