Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support lifecycle ignoreChanges with module #94

Open
1 task done
Hi-Fi opened this issue Apr 12, 2024 · 5 comments
Open
1 task done

feat: Support lifecycle ignoreChanges with module #94

Hi-Fi opened this issue Apr 12, 2024 · 5 comments
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Needs: External Changes ⚒️ When an issue/PR requires changes that are outside of the control of the module. e.g. to an RP. Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: Feature Request ➕ New feature or request

Comments

@Hi-Fi
Copy link

Hi-Fi commented Apr 12, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

(Optional) Module Version

0.5.3

(Optional) Correlation Id

No response

Description

As Terraform doesn't support lifecycle meta-argument with modules (see hashicorp/terraform#27360) it would be nice that module would allow ignoring some things that are (at least in our environment) handled with policies. Of course the ignore can be more generic if possible, but at least for use tags and private_dns_zone_group.

@Hi-Fi Hi-Fi added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Triage 🔍 Maintainers need to triage still labels Apr 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label May 6, 2024
@matt-FFFFFF matt-FFFFFF removed Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Jun 4, 2024
@matt-FFFFFF
Copy link
Member

Hi - we cannot support this due to limitations in Terraform - will keep open to track

@matt-FFFFFF matt-FFFFFF added the Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities label Jun 10, 2024
@rick-pb
Copy link

rick-pb commented Jul 9, 2024

are you able to provide an explanation of why this isn't supported? ignore changes should be able to be able to be added to the resource in the module.

@matt-FFFFFF
Copy link
Member

Entries in ignore_changes must be static and cannot be passed in as variables.

Also they cannot be passed in through a call to a module.

Hence we are not able to provide a configurable list

@matt-FFFFFF
Copy link
Member

However we have solved private dns zone group as we have a variable to control whether we manage this or not

@matt-FFFFFF matt-FFFFFF added the Needs: External Changes ⚒️ When an issue/PR requires changes that are outside of the control of the module. e.g. to an RP. label Aug 19, 2024
@oocx
Copy link

oocx commented Feb 7, 2025

Another use case for ignore_changes: I'm currently trying to create a secret, where the value is updated outside of terraform. Because I can't ignore changes to the secrets value, terraform tries to reset it to it's initial value that is specified in my terraform configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Needs: External Changes ⚒️ When an issue/PR requires changes that are outside of the control of the module. e.g. to an RP. Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: Feature Request ➕ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants