Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_public_ip prevents support of azurerm provider >= 3.0.0 #319

Closed
krowlandson opened this issue Mar 31, 2022 · 3 comments · Fixed by #345
Closed

azurerm_public_ip prevents support of azurerm provider >= 3.0.0 #319

krowlandson opened this issue Mar 31, 2022 · 3 comments · Fixed by #345
Labels
bug Something isn't working external bug PR-merged

Comments

@krowlandson
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: any

azure provider: v3.0.0 onwards

module: any

Description

Describe the bug

As mentioned in #309, the following error occurs when using the latest v3.0.0 or newer version of the Azure provider for Terraform:

│ Error: Unsupported argument
│ 
│   on .terraform/modules/enterprise_scale/resources.connectivity.tf line 122, in resource "azurerm_public_ip" "connectivity":
│  122:   availability_zone       = each.value.template.availability_zone
│ 
│ An argument named "availability_zone" is not expected here.

Steps to Reproduce

  1. Configure a root module using v1.1.4 of the module, and set a version constraint on the provider required version to v3.0.0 or later.
  2. Run terraform init -upgrade
  3. Run terraform plan
  4. Observe the error.

Screenshots

Additional context

This resource attribute was "hard" deprecated in v3.0.0 so no opportunity was available to make the transition whilst offering support for v2.x of the provider.

As such, this will require a complete shift of the module only support provider versions from v3.0.0 onwards. v2.x of the provider will no longer work so need to consider whether this requires a major release to support, or will minor suffice?

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 31, 2022
@krowlandson krowlandson added bug Something isn't working and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 31, 2022
@krowlandson krowlandson changed the title Bug Report Unsupported argument availability_zone on azurerm_public_ip resource on provider versions v3.0.0 onwards Mar 31, 2022
@matt-FFFFFF matt-FFFFFF changed the title Unsupported argument availability_zone on azurerm_public_ip resource on provider versions v3.0.0 onwards azurerm_public_ip prevents support of azurerm provider >= 3.0.0 Mar 31, 2022
@matt-FFFFFF matt-FFFFFF pinned this issue Mar 31, 2022
@roblongdon-wpp
Copy link

Can confirm that pinning the azurerm provider to <3.0.0 is a workaround for now.

@krowlandson
Copy link
Contributor Author

Thank you for confirming @roblongdon-wpp... if you are using the latest v1.1.4 release, this version constraint should be already included within the module, but we still recommend that you pin to a specific provider version in your root module configuration.

@krowlandson krowlandson mentioned this issue Apr 22, 2022
6 tasks
@ghost ghost added the PR-referenced label Apr 22, 2022
@ghost ghost added PR-merged and removed PR-referenced labels Apr 25, 2022
@matt-FFFFFF
Copy link
Member

Please see v2.0.0 release that supports v3.0.2 and above of the provider.

@matt-FFFFFF matt-FFFFFF unpinned this issue Apr 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working external bug PR-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants