Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

make var.use_for_each a required variable #93

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

lonegunmanb
Copy link
Member

Describe your changes

In 3.2.0 we've introduced a new variable use_for_each(#92). To keep the backward compatible, we set false as the default value.

This pr would remove this default value and make the variable a required variable, we encourage users who're creating a new stack, we encourage them to use true.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests December 8, 2022 13:14 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Potential Breaking Changes in 692af67:
[update] "Variables.use_for_each.Default" from 'false' to ''

@lonegunmanb lonegunmanb temporarily deployed to acctests December 9, 2022 00:24 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Potential Breaking Changes in dab7359:
[update] "Variables.use_for_each.Default" from 'false' to ''

@github-actions
Copy link
Contributor

Potential Breaking Changes in f5ffaf2:
[update] "Variables.use_for_each.Default" from 'false' to ''

@github-actions
Copy link
Contributor

Potential Breaking Changes in 52f5fea:
[update] "Variables.use_for_each.Default" from 'false' to ''

Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 🚀

@jiaweitao001 jiaweitao001 merged commit d2b271f into Azure:master Dec 27, 2022
@lonegunmanb lonegunmanb deleted the fourpointo branch May 6, 2023 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants