Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh subscriptions after adding and deleting clusters #415

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Refresh subscriptions after adding and deleting clusters #415

merged 1 commit into from
Jan 3, 2024

Conversation

peterbom
Copy link
Contributor

@peterbom peterbom commented Jan 3, 2024

Programmatically refresh the Cloud Explorer treeview after adding and deleting clusters.

This builds on the command to refresh the clusters under a subscription in the treeview (#393), and makes use of the slightly more constrained interface for interacting with TreeView items (#406).

@Tatsinnit Tatsinnit added the enhancement 🚀 New feature or request or improvements on existing code. label Jan 3, 2024
Tatsinnit
Tatsinnit approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊❤️🙏☕️ Thank you for this. Looks good to me, for archive only, folks can argue about the intervals, I at this stage has no preference so looks good to me, if in future anyone wants to start a discussion, I think comment is in place for discussion.

@peterbom
Copy link
Contributor Author

peterbom commented Jan 3, 2024

Thanks @Tatsinnit!

for archive only, folks can argue about the intervals, I at this stage has no preference so looks good to me, if in future anyone wants to start a discussion, I think comment is in place for discussion.

Good point. You're referring to the refresh intervals for refreshing after cluster deletion, right? Just for the record, when I tried it, the updated list came back after the 30s interval. I have no idea what kind of caching is going on internally, so it could conceivably take significantly less or more time. I think the current list avoids hammering the API too much, while still refreshing reasonably responsively. Worst case, the user can refresh manually with the refresh button.

@Tatsinnit
Copy link
Member

Tatsinnit commented Jan 3, 2024 •
edited
Loading

Thanks @Tatsinnit!

for archive only, folks can argue about the intervals, I at this stage has no preference so looks good to me, if in future anyone wants to start a discussion, I think comment is in place for discussion.

Good point. You're referring to the refresh intervals for refreshing after cluster deletion, right? Just for the record, when I tried it, the updated list came back after the 30s interval. I have no idea what kind of caching is going on internally, so it could conceivably take significantly less or more time. I think the current list avoids hammering the API too much, while still refreshing reasonably responsively. Worst case, the user can refresh manually with the refresh button.

:shipit:

@Tatsinnit Tatsinnit merged commit 58384bd into Azure:main Jan 3, 2024
4 checks passed
@Tatsinnit Tatsinnit linked an issue Jan 4, 2024 that may be closed by this pull request
Add refresh ability to cluster properties page #291
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit approved these changes

Assignees

@peterbom peterbom

Labels
enhancement 🚀 New feature or request or improvements on existing code.
Projects
AKS Extension Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add refresh ability to cluster properties page
2 participants
@peterbom @Tatsinnit