Allow recovery from cancelled Azure sign-in

[peterbom]

Is your feature request related to a problem? Please describe.

[Copied from here]
If you cancel/close the browser-based authentication for a sign-in request, subsequent sign-in attempts are left hanging indefinitely. The steps are:

• You sign in using the "AKS: Sign in to Azure..." command
• You select the "Sign in to another account" option (or it's your first time signing in)
• A browser authentication window opens up
• You close that window without completing the sign-in process

In that case VS Code thinks you're still signing in (there's no way it can be notified you've closed the browser tab). And if you try to sign in again, it waits for the original sign-in request to complete. This behaviour is part of the VS Code API and beyond our control. It is documented as a feature request in the VS Code repo, with the request being to support cancellation. The discussion suggests the request will eventually time out, but I can't find the duration documented and in any case it's a very long time. The issue has been in its current state for 3 years, so it doesn't look as if it'll see any movement anytime soon.

Mention what platform you want to support the new feature

All

Describe the solution you'd like

If it were to be fixed (i.e. the API changed to support cancellation) we could present a popup similar to the Azure Account one:

Describe alternatives you've considered

One thing we could do is display a cancellation dialog (like the one above), and if the user cancels we invoke the 'reload window' command. It's a bit of a sledgehammer approach, but it's currently the only way I can see for the user to get out of the trap. Reloading the window could cause users to lose context in whatever they are doing, which could cause problems for them in ways that are hard for us to predict.

As it is, I'm reluctant to make further changes at this stage, for what I hope is a relatively infrequent scenario.

Additional context

The VS Code API options are documented here. You might expect that clearSessionPreference or forceNewSession would cause VS Code to abandon its existing authentication process, but these do not have that effect.

[peterbom]

Fixed in underlying VS Code repo.