Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to fallback to global endpoint if region detection through environment variable and imds fails. #2287

Closed
neha-bhargava opened this issue Dec 8, 2020 · 2 comments
Assignees
Milestone

Comments

@neha-bhargava
Copy link
Contributor

neha-bhargava commented Dec 8, 2020

In case MSAL fails to detect the region, fallback to global endpoint.

Please refer to the design doc for details.

Currently we will only fallback to global when region detection fails and not when regional ests fail. For regional ests failures we are waiting on the ests-r team to provide us with the allow list of errors for which we need to fallback to global.

  • Add an api FallbackToGlobal in the confidential client WithAzureRegion(AutoDetectRegion: true, FallbackToGlobal: true)
  • Fallback logic in case we fail to detect the region -- first request decides this and then cache
  • Add to telemetry if we are falling back to global for the request
@bgavrilMS
Copy link
Member

@neha-bhargava @trwalke - isn't this done?

@trwalke trwalke added the Fixed label Jan 14, 2021
@pmaytak
Copy link
Contributor

pmaytak commented Jan 20, 2021

This is included in MSAL 4.25.0 release.

@pmaytak pmaytak closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants