Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add WAM Support to a separate package for netfwk and netcore #2300

Closed
henrik-me opened this issue Dec 11, 2020 · 3 comments · Fixed by #2306
Closed

[Feature] Add WAM Support to a separate package for netfwk and netcore #2300

henrik-me opened this issue Dec 11, 2020 · 3 comments · Fixed by #2306

Comments

@henrik-me
Copy link
Contributor

Issues with dependencies are/were causing trouble updating to the latest MSAL for ASP.NET to address this we will be adding WAM support to a separate package.

Final design TBD

Related Issues:
Removal from Core package: #2299
Challenge: #2247

@henrik-me henrik-me changed the title [Bug] Add WAM Support to a separate package for netfwk and netcore [Feature] Add WAM Support to a separate package for netfwk and netcore Dec 11, 2020
@henrik-me henrik-me added this to the 4.26.0 milestone Dec 11, 2020
@charlesroddie
Copy link

How are you going to make this discoverable? I assume that WAM is necessary to make authentication work correctly on Windows. Then how are consumers of this library informed that they will need to install it and integrate it on order to get their windows App working properly?

@jmprieur
Copy link
Contributor

We are still thinking of what the best experience could be

@charlesroddie: If you are using .NET 5, there is a distinction between the the desktop platform and the web platform, and therefore, .WithBroker(true) would be available.

For .NET 4.6.1, 4.5, we could have .WithBroker throwing a meaningful exception telling you to add the separate NuGet package

Any feedback or idea is welcome.

@pmaytak
Copy link
Contributor

pmaytak commented Jan 20, 2021

This is included in MSAL 4.25.0 release.

@pmaytak pmaytak closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants