Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [L] MSAL.NET supports Prompt.Create so that customers can implement self-service sign-up #2463

Closed
5 tasks done
jmprieur opened this issue Mar 9, 2021 · 7 comments
Assignees
Milestone

Comments

@jmprieur
Copy link
Contributor

jmprieur commented Mar 9, 2021

Is your feature request related to a problem? Please describe.
When developers want to implement self-service sign up for their apps, they can use a prompt=create, triggered by a "Sign-up" link in their app. The end user can then enter the 'create account' experience.

Describe the solution you'd like
MSAL.NET should propose a new property named Create in the Prompt class. When using this property, MSAL.NET would send 'prompt=create' to the authorize endpoint, which will trigger the sign-up experience.

Additional context

Example URL:
https://login.microsoftonline.com/d014fd44-d398-4813-a3a9-8cd725f7f356/oauth2/authorize?
client_id=da53de5a-636b-425f-ad57-0f62d6f974c7
&response_type=id_token
&resource=da53de5a-636b-425f-ad57-0f62d6f974c7
&scope=openid
&nonce=default_nonce
&redirect_uri=https://jwt.ms
&prompt=create

image

The draft OIDC spec for this is here: https://openid.net/specs/openid-connect-prompt-create-1_0.html

Work to do

  • Expose a new Create property in Prompt.
  • Wire-up the prompt so that 'prompt=create' is sent to the authorize endpoint when this prompt is used.
  • Update the wiki page, or better redirect it to the docs.ms page, which would, however need to be synced
    Update after release
  • Update the docs.ms AcquireToken desktop scenario page.
    MS Docs PR Merge after release
  • Update Microsoft.Identity.Web documentation to explain how to trigger a sign-up experience
    Updated: Web Apps / Enabling sign-up experience

Out of scope for this work item:

@jmprieur
Copy link
Contributor Author

jmprieur commented Mar 9, 2021

@bgavrilMS this is something we committed to for Q3. I'd suggest we take it for next sprint / the release after next

cc: @henrik-me

@bgavrilMS bgavrilMS changed the title [Feature Request] MSAL.NET supports Prompt.Create so that customers can implement self-service sign-up [Feature Request] [S] MSAL.NET supports Prompt.Create so that customers can implement self-service sign-up Mar 11, 2021
@bgavrilMS bgavrilMS changed the title [Feature Request] [S] MSAL.NET supports Prompt.Create so that customers can implement self-service sign-up [Feature Request] [L] MSAL.NET supports Prompt.Create so that customers can implement self-service sign-up Mar 11, 2021
@bgavrilMS
Copy link
Member

Not applicable to WAM

@bgavrilMS
Copy link
Member

@jmprieur - this prompt works for the application you provided in the example, but not for others. This will be confusing to people. Is there a config in the app registration that must be performed?

@jmprieur
Copy link
Contributor Author

@bgavrilMS
yes there is an app registration that needs to be performed, @bgavrilMS: this is for external identities:https://docs.microsoft.com/en-us/azure/active-directory/external-identities/self-service-sign-up-user-flow

@jmprieur
Copy link
Contributor Author

We probably don't want to update the samples ...?

@pmaytak pmaytak added Fixed and removed In Progress labels Mar 24, 2021
@pmaytak
Copy link
Contributor

pmaytak commented Mar 25, 2021

@jmprieur @jennyf19
For Identity Web, I updated Web Apps / Enabling sign-up experience wiki. Would it be useful to add that SignUp action to Identity.Web.UI AccountController?

@jmprieur
Copy link
Contributor Author

@pmaytak : I don't think so ... this is only for external identities ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants