Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] MSAL not sending correct OS version string on .NET classic #2517

Closed
bgavrilMS opened this issue Mar 30, 2021 · 1 comment · Fixed by #2516
Closed

[Bug] MSAL not sending correct OS version string on .NET classic #2517

bgavrilMS opened this issue Mar 30, 2021 · 1 comment · Fixed by #2516
Labels
bug P2 Supportability
Milestone
4.30.0

Comments

@bgavrilMS
Copy link
Member

msal 4.29

MSAL sends x-client-os header with version string. THis is used by the server for device auth.
On .NET classic, this functionality is broken, as we mostly just send "6.2.5900" due to a bug in .NET fwk (see https://stackoverflow.com/questions/33328739/system-environment-osversion-returns-wrong-version)

This fixes the issue by send the correct OS description, e.g. "Windows 10", "Windows Server 2016" etc.
@bgavrilMS bgavrilMS linked a pull request Mar 30, 2021 that will close this issue
Bogavril/x client os #2516
Merged
@jmprieur jmprieur mentioned this issue Mar 30, 2021
Merged
@bgavrilMS bgavrilMS added this to the 4.30 milestone Mar 31, 2021
@pmaytak
Copy link
Contributor

pmaytak commented Apr 22, 2021

This is included in MSAL 4.30.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug P2 Supportability
Projects
None yet
Milestone
4.30.0
Development

Successfully merging a pull request may close this issue.

Bogavril/x client os AzureAD/microsoft-authentication-library-for-dotnet
2 participants
@bgavrilMS @pmaytak