Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] [2L 5S] OBO to perform refresh_token flow #2623

Closed
4 of 7 tasks
bgavrilMS opened this issue May 13, 2021 · 2 comments · Fixed by #2667
Closed
4 of 7 tasks

[Feature Request] [2L 5S] OBO to perform refresh_token flow #2623

bgavrilMS opened this issue May 13, 2021 · 2 comments · Fixed by #2667
Assignees
@trwalke @neha-bhargava
Labels
Feature Request
Milestone
4.33.0

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented May 13, 2021 •
edited by jmprieur
Loading

Change OBO as per https://identitydivision.visualstudio.com/DevEx/_git/AuthLibrariesApiReview?version=GBdev&path=%2FConfidentialClient%2FOBO.md

  • add user_assertion_hash to RT as well as AT [S]
  • change OBO logic to perform refresh_token flow [L]
  • in refresh_token flow, only use RT associated with user_assertion_hash [S]
  • E2E Test: OBO with expired AT and valid RT in cache [L]
  • E2E Test: OBO with expired AT and missing RT in cache [S]
  • E2E Test: OBO with expired AT and RT not associated with user_assertion_hash in cache [S]
  • Test that this is not a breaking change, i.e. GetAccounts / AcquireTokenSilent behave as expected [S]

See also: #2558 for the scenario
@bgavrilMS bgavrilMS changed the title OBO update [Feature Request] OBO to perform refresh_token flow May 13, 2021
@bgavrilMS bgavrilMS added this to the 4.32.0 milestone May 13, 2021
@bgavrilMS bgavrilMS changed the title [Feature Request] OBO to perform refresh_token flow [Feature Request] [L] OBO to perform refresh_token flow May 13, 2021
@bgavrilMS bgavrilMS changed the title [Feature Request] [L] OBO to perform refresh_token flow [Feature Request] [2L 5S] OBO to perform refresh_token flow May 13, 2021
@bgavrilMS
Copy link
Member Author

Will resolve issues #2447 #2558

@pmaytak pmaytak self-assigned this May 26, 2021
@pmaytak pmaytak removed their assignment May 26, 2021
@neha-bhargava neha-bhargava self-assigned this May 26, 2021
@trwalke trwalke self-assigned this May 26, 2021
@neha-bhargava neha-bhargava mentioned this issue May 27, 2021
Merged
9 tasks
@jmprieur jmprieur mentioned this issue May 28, 2021
Closed
@jmprieur
Copy link
Contributor

See also AzureAD/microsoft-identity-web#441

@bgavrilMS bgavrilMS modified the milestones: 4.32.0, 4.33.0 Jun 3, 2021
@bgavrilMS bgavrilMS linked a pull request Jun 14, 2021 that will close this issue
Add refresh token flow to OBO #2667
Merged
9 tasks
@bgavrilMS bgavrilMS mentioned this issue Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwalke trwalke

@neha-bhargava neha-bhargava

Labels
Feature Request
Projects
None yet
Milestone
4.33.0
Development

Successfully merging a pull request may close this issue.

Add refresh token flow to OBO AzureAD/microsoft-authentication-library-for-dotnet
6 participants
@bgavrilMS @jmprieur @trwalke @pmaytak @henrik-me @neha-bhargava