Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] [SPIKE] OBO for SP does not work when refreshing the RT #2817

Closed
1 of 4 tasks
SameerK-MSFT opened this issue Aug 11, 2021 · 3 comments · Fixed by #3266
Closed
1 of 4 tasks

[Feature Request] [SPIKE] OBO for SP does not work when refreshing the RT #2817

SameerK-MSFT opened this issue Aug 11, 2021 · 3 comments · Fixed by #3266
Assignees
@trwalke
Labels
Feature Request
Milestone
4.43.2

Comments

@SameerK-MSFT
Copy link
Contributor

SameerK-MSFT commented Aug 11, 2021 •
edited by trwalke
Loading

The spike should focus on reusing the existing APIs and the UserTokenCache.

  • Do the existing OBO APIs make sense for SP?
  • What does it take to refresh the RT?
  • Should the API use the AppTokenCache?
  • How will token caching be done? (e.g. cache keys)
@bgavrilMS bgavrilMS changed the title [Bug] Multi-hop OBO for SP does not work [Bug] OBO for SP does not work when refreshing the RT Aug 12, 2021
@bgavrilMS bgavrilMS added this to the 4.36.0 milestone Aug 12, 2021
@pmaytak pmaytak added bug and removed bug labels Aug 12, 2021
@bgavrilMS bgavrilMS changed the title [Bug] OBO for SP does not work when refreshing the RT [Feature Request] OBO for SP does not work when refreshing the RT Aug 12, 2021
@pmaytak pmaytak modified the milestones: 4.36.0, 4.37.0 Aug 31, 2021
@pmaytak pmaytak modified the milestones: 4.37.0, 4.38.0 Oct 23, 2021
@bgavrilMS bgavrilMS removed this from the 4.38.0 milestone Oct 26, 2021
@bgavrilMS bgavrilMS changed the title [Feature Request] OBO for SP does not work when refreshing the RT [Feature Request] [SPIKE] OBO for SP does not work when refreshing the RT Nov 11, 2021
@bgavrilMS bgavrilMS changed the title [Feature Request] [SPIKE] OBO for SP does not work when refreshing the RT [Feature Request] Q3 [SPIKE] OBO for SP does not work when refreshing the RT Nov 11, 2021
@bgavrilMS bgavrilMS changed the title [Feature Request] Q3 [SPIKE] OBO for SP does not work when refreshing the RT [Feature Request] [SPIKE] OBO for SP does not work when refreshing the RT Nov 11, 2021
@bgavrilMS bgavrilMS added this to the 4.39.0 milestone Nov 15, 2021
@pmaytak pmaytak modified the milestones: 4.39.0, 4.40.0 Nov 29, 2021
@pmaytak pmaytak removed this from the 4.40.0 milestone Jan 11, 2022
@bgavrilMS bgavrilMS mentioned this issue Feb 7, 2022
Open
@sean-yao
Copy link

sean-yao commented Mar 3, 2022

Any ETA for supporting this?

@trwalke trwalke self-assigned this Mar 29, 2022
@trwalke
Copy link
Member

trwalke commented Mar 30, 2022

Seems like the PPE app we use to test this scenario suddenly starting working for the refresh flow scenario too. need to recreate apps in 1st/3rd party portal to test

@bgavrilMS bgavrilMS mentioned this issue Apr 6, 2022
Merged
@bgavrilMS bgavrilMS reopened this Apr 15, 2022
@pmaytak pmaytak added this to the 4.43.2 milestone May 3, 2022
@pmaytak
Copy link
Contributor

pmaytak commented May 3, 2022

Released in 4.43.2.

@pmaytak pmaytak closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwalke trwalke

Labels
Feature Request
Projects
None yet
Milestone
4.43.2
Development

Successfully merging a pull request may close this issue.

OBO for SP with RT support AzureAD/microsoft-authentication-library-for-dotnet
5 participants
@bgavrilMS @trwalke @pmaytak @sean-yao @SameerK-MSFT