Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] WithAzureRegion and WithCustomInstanceMetadata are mutually exclusive #3014

Closed
bgavrilMS opened this issue Nov 15, 2021 · 0 comments · Fixed by #3116
Closed

[Bug] WithAzureRegion and WithCustomInstanceMetadata are mutually exclusive #3014

bgavrilMS opened this issue Nov 15, 2021 · 0 comments · Fixed by #3116
Assignees
@neha-bhargava
Labels
bug P3 Supportability
Milestone
4.41.0

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Nov 15, 2021 •
edited
Loading

msal 4.37

  1. Configure both WithAzureRegion("region") and WithCustomInstanceMetadata(metadata)
  2. set medatadata to smth like
                "{{\"api-version\":\"1.1\",\"metadata\":[{{\"preferred_network\":\"{0}\",\"preferred_cache\":\"{0}\",\"aliases\":[\"{0}\",]}}]}}";

Actual: WithCustomInstanceMetadata overrides with region
Expected: An exception message preventing the use of both options
@bgavrilMS bgavrilMS added this to the 4.39.0 milestone Nov 15, 2021
@bgavrilMS bgavrilMS added P3 and removed P2 labels Nov 15, 2021
@pmaytak pmaytak modified the milestones: 4.39.0, 4.40.0 Nov 29, 2021
@pmaytak pmaytak removed this from the 4.40.0 milestone Jan 11, 2022
@bgavrilMS bgavrilMS added this to the 4.41.0 milestone Jan 13, 2022
@neha-bhargava neha-bhargava self-assigned this Jan 13, 2022
@neha-bhargava neha-bhargava mentioned this issue Jan 18, 2022
Merged
@neha-bhargava neha-bhargava linked a pull request Jan 19, 2022 that will close this issue
Add exception when both region and custom instance metadata is config… #3116
Merged
@bgavrilMS bgavrilMS mentioned this issue Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neha-bhargava neha-bhargava

Labels
bug P3 Supportability
Projects
None yet
Milestone
4.41.0
3 participants
@bgavrilMS @pmaytak @neha-bhargava