Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Edge System browser support for Linux Broker #3051

Closed
4 tasks
maliksahil opened this issue Dec 3, 2021 · 5 comments · Fixed by #3129
Closed
4 tasks

[Feature Request] Edge System browser support for Linux Broker #3051

maliksahil opened this issue Dec 3, 2021 · 5 comments · Fixed by #3129
Assignees
Milestone

Comments

@maliksahil
Copy link

maliksahil commented Dec 3, 2021

Is your feature request related to a problem? Please describe.
Customers wish to integrate with Linux Broker. A short term win may be to use system browser to offer integration with linux broker.

Describe the solution you'd like
Allow the developer to specify a specific browser (edge) when operating on Linux. The .WithBroker() call could then use edge to integrate with linux broker.

Describe alternatives you've considered
Wrapping OneAuthMSAL would be a great alternative, but is probably higher effort/down the road.

Additional context
Add any other context or screenshots about the feature request here.

  • Figure out if we can detect if Edge is installed (see Ray's comments below)
  • Figure out if there is way to start Edge on Linux instead of the regular "xdg-open"
  • If all of this is possible, start Edge if it is installed and WithBroker is set to true
  • If not possible, contact Edge team and ask for guidance
@bgavrilMS
Copy link
Member

bgavrilMS commented Dec 6, 2021

@rayluo - did you say you were working on this for msal.py? Is there a way to start edge on Linux and to check that Edge exists?

@rayluo
Copy link
Contributor

rayluo commented Dec 6, 2021

@rayluo - did you say you were working on this for msal.py?

Regarding launching a standard Edge, that part has already been finished, tested, and shipped in msal python. We are just recently discussing about the end-to-end test since the broker-enabled Edge-dev becomes available.

Is there a way to start edge on Linux and to check that Edge exists?

MSAL Python detects Edge's existence by using its default installation path that we observed: /usr/bin/microsoft-edge. Python language happens to provide a built-in module to launch a specific browser, I believe it is essentially spawning a process to run the browser executable file with a given url.

@pmaytak pmaytak removed this from the 4.40.0 milestone Jan 11, 2022
@bgavrilMS bgavrilMS changed the title [Feature Request] System browser support for Linux Broker [Feature Request] Edge System browser support for Linux Broker Jan 13, 2022
@neha-bhargava
Copy link
Contributor

@bgavrilMS @maliksahil In case edge is unavailable do we throw an exception or just open the browser using xdg-open?

@bgavrilMS
Copy link
Member

Yes, the logic should be:

  • if the broker is enabled then try to use Edge, but if not found, use any browser (xdg-open)

@pmaytak pmaytak added this to the 4.41.0 milestone Jan 27, 2022
@pmaytak pmaytak closed this as completed Feb 5, 2022
@gladjohn
Copy link
Contributor

gladjohn commented Feb 9, 2022

This has been fixed in MSAL 4.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants