Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveAdalUser internal API does not remove all relevant Adal cache entities (migrarion form adalv3 to adalv4 to msal2 scenario) #652

Closed
SomkaPe opened this issue Oct 22, 2018 · 1 comment

Comments

@SomkaPe
Copy link
Contributor

SomkaPe commented Oct 22, 2018

RemoveAdalUser internal API remove users only by accountId.
This approach does not work for next scenario:
if you get AT for res1 in adal v3 than migrate to adal v4 and get token to res2 you will have next state of the cache:
for the same Account you have one entity in adal cache in adalv3 format (no client info)
another entity in adal v4 format (with client info).
So you have two Adal cache entities for the same account .

If you migrate to Msal and call get accounts api one Account object will be returned.
If you call Remove account it will remove only V4 adal entity , so next call to get accounts will return same account object (this time with id null)

So remove account api will not remove account .

RemoveAdalUser api should remove users by accountId and by displayableId ( to cover scenario of
migrarion form adalv3 to adalv4 to msal2)

@jennyf19
Copy link
Collaborator

jennyf19 commented Nov 9, 2018

Fixed in latest release Msal2.4.0-preview.

@jennyf19 jennyf19 closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants