Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASWebAuthenticationSession is skipped due to AppCenter build flags #919

Closed
jennyf19 opened this issue Feb 27, 2019 · 0 comments
Closed

ASWebAuthenticationSession is skipped due to AppCenter build flags #919

jennyf19 opened this issue Feb 27, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@jennyf19
Copy link
Collaborator

jennyf19 commented Feb 27, 2019

Which Version of MSAL are you using ?
2.2.7 and 3.x

Platform
Xamarin iOS

Repro
Use an iOS 12+ device.
Interactive login
SFAuthenticationSession is used

Expected behavior
ASWebAuthenticationSession should be used

Possible Solution
Put a breakpoint here and check that the device is 12+ and ASWebAuthSession is being used for authentication. Check w/iOS 11 device and 10< device as well to make sure everything is hit correctly.

The flags currently used: #if BUILDENV != APPCENTER are build flags and not set.

Fix needs to go into v2 and v3.

@jmprieur jmprieur added the bug label Feb 28, 2019
@jmprieur jmprieur added this to the 3.1 milestone Feb 28, 2019
@jmprieur jmprieur added the Fixed label Mar 1, 2019
@trwalke trwalke closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants