-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 15 support #5410
Comments
i think that since Ivy is required in Angular v15, then this is connected to #4298 maybe? |
Assigning to @EmLauber for tracking. This should get picked up in Q1 2023. |
stopped me dead in my tracks after promoting azure B2C and Angular. hard to believe that MS can't/won't keep up with the NG release cycle given the HUGE number of corporate integrations there are. |
@jerone This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale. |
Hi @EmLauber, I wanted to create an issue, but there is no option for selecting v3 of MSAL-Angular. As for Angular 16 sample, it would be great if you could also make "standalone" sample. In Angular v16, there is even an option in CLI "ng new --standalone" which completely removes modules when creating new Angular app. |
For those that experienced yarn or other package manager issues, v3 alpha-1 is out and should address those problems.
We are updating our drop downs. For now you can just enter the version as v3 alpha in the version field for the wrapper.
I'll pass along this feedback. Our priority is validating v3 and existing sample works with Angular 16, then we can iterate on other samples for Angular 16. |
Thank you! |
what is the solution or partial workaround for this error about angular and msal version incompatibility. |
@dansau84 The temporary workaround I'm doing is just adding this to my package.json: "dependencies": {
"@azure/msal-angular": "3.0.0-alpha.2",
"@azure/msal-browser": "3.0.0-alpha.2",
...
},
"resolutions": {
"@azure/msal-browser": "3.0.0-alpha.2"
},
"overrides": {
"@azure/msal-browser": "3.0.0-alpha.2"
} That way both npm and yarn will grab that specific version I want. |
Not having an msal package that is ivy compatible is a showstopper for Angular 16 migration as ngcc was removed. Microsoft is aware of this problem for at least 3-4 months. Still you seem to have all the time in the world … I really have to state that this is a very poor performance for an enterprise auth system like Azure AD … verry disappointing 🤬 |
@EmLauber Could you please give a short feedback on the current state? :) |
Ivy support is available in our latest major release, MSAL.Angular v3. The release is still in alpha as we gather feedback and we are releasing updates with that feedback. You can help us by testing v3 alpha and creating new issues for any bugs you find. I am leaving this issue about Angular 15 support open until v3 is out of pre-release. |
@EmLauber Any chance of getting faster releases? For an alpha, I was hoping for more like weekly pushes. |
Anyone get v3 working with a standalone app? I'm getting issues as soon as i add the MsalInterceptor using:
|
@EricBichara |
The angular v16 sample still uses the old way |
Just updated our app to |
when will be published the new @azure/msal-angular library update that isn't an alpha that supports angular 15 and 16? |
I think there needs to be a push to get a fully working production release of this. Not supporting Angular 16 is one thing, but Angular 15 was released 8 months ago. |
+1 for SirMrJames. V16 Bombs out meaning I'll have to remain on (equally an unsupported) v15 due to this. |
Could you please give us some hindsights of when a stable v3 version will be released? As already mentioned here, using a beta version is a showstopper for some companies. FYI, we tested MSAL |
I raised this issue 8 months ago (tomorrow exactly) for Angular 15, almost a month before it's official release. For a huge company like Microsoft, for a product that screams security, this is a huge let down. 😢 How many of Microsoft products use this library, I'm scared now. |
@devfservant: I also switched from Angular 15 and MSAL 2.x to Angular 16 and MSAL 3.0.0-beta.1 and it worked with no problem. But I agree with @jerone: Do we want to deploy beta versions to production? Shame on you MSAL Team!!! |
any news when beta will be over ? |
@devfservant If you are hosting on azure you could use easy auth instead of msal … supported on static web app, container apps, app services, … it also allows you to get hold of id- and access tokens … https://learn.microsoft.com/en-us/azure/static-web-apps/authentication-authorization https://learn.microsoft.com/en-us/azure/container-apps/authentication |
Version 3.0.0 just released, however I still get the same error when on Angular 16. (Cannot find module '@azure/msal-angular' or its corresponding type declarations.) |
@achrysanthakopoulou |
Hi all, there was an issue with our release process, and we are currently working on a fix. Thank you all for your patience. |
@jo-arroyo Have all issues, regarding support for Angular 15 & 16, officially been resolved? |
Yes, the releases issues were resolved with the patch v3.0.1. I am closing this issue as support for Angular 15 & 16 is now GA. Please see our migration guide for MSAL.Angular v2 to v3. |
Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
Latest
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
Latest
Public or Confidential Client?
Public
Description
Will MSAL support Angular 15.
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
No response
Source
External (Customer)
The text was updated successfully, but these errors were encountered: