Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Enable deterministic builds for NuGet packages #1308

Closed
jennyf19 opened this issue Jul 10, 2021 · 1 comment
Closed

[Bug] Enable deterministic builds for NuGet packages #1308

jennyf19 opened this issue Jul 10, 2021 · 1 comment
Labels
build pipeline fundamentals
Milestone
1.14.1

Comments

@jennyf19
Copy link
Collaborator

jennyf19 commented Jul 10, 2021 •
edited
Loading

Open the nuget package with NugetPackageExplorer
Under Health it can be observed that deterministic (dll/exe) is flagged for an error.

The solution is that the ContinuousIntegrationBuild MSBuild property has to be set to true when built on CI. In practice that means something like this in your directory props/targets file.

  <PropertyGroup Condition="'$(TF_BUILD)' == 'true'">
    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
  </PropertyGroup>

Reference
@jennyf19 jennyf19 added this to the 1.15 milestone Jul 10, 2021
@jennyf19 jennyf19 mentioned this issue Jul 12, 2021
Merged
@jmprieur jmprieur changed the title [Bug] Enable deterministic builds [Bug] Enable deterministic builds for NuGet packages Jul 15, 2021
@jennyf19
Copy link
Collaborator Author

Included in 1.14.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build pipeline fundamentals
Projects
None yet
Milestone
1.14.1
Development

No branches or pull requests
1 participant
@jennyf19