Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement C# 8.0 nullable standard #15

Closed
jennyf19 opened this issue Feb 18, 2020 · 4 comments
Closed

Implement C# 8.0 nullable standard #15

jennyf19 opened this issue Feb 18, 2020 · 4 comments
Assignees
Labels

Comments

@jennyf19
Copy link
Collaborator

from @sujayvsarma and copied from Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2#249

Even if the project is not C# 8.0, consider implementing the nullable standard by suffixing ? to all parameters and returns that may be NULL.

This will be a breaking changing internal to the library & to consuming code. Therefore, consider publishing the changes only during a major cycle.

@bgavrilMS
Copy link
Member

That would be very cool indeed and the best time to do it is before releasing. Happy to help with this one, should not be too hard.

This blog describes the feature better https://devblogs.microsoft.com/dotnet/embracing-nullable-reference-types/

To quote from the blog:

Libraries can accurately describe the null behavior of the APIs, in a way that is checkable in client code at the call site. This raises expressiveness on API boundaries so that everyone can get a handle on the safe propagation and dereferencing of nulls. Nobody likes null reference exceptions or argument-null exceptions! This helps you write the code right the first time, and avoid the sources of those exceptions before you even compile and run the code.

@jennyf19 jennyf19 added this to the 0.2.0-preview milestone May 22, 2020
@bgavrilMS bgavrilMS self-assigned this May 29, 2020
@jennyf19
Copy link
Collaborator Author

jennyf19 commented Jun 5, 2020

@bgavrilMS or @pmaytak can you put this in the correct milestone please? not a breaking change. thx

@jmprieur
Copy link
Collaborator

@bgavrilMS @jennyf19 @pmaytak @henrik-me
Talking with the ASP.NET Core team, ASP.NET Core 5 will support the nullable types.
BTW Barry mentioned the this is causing issues to ASP.NET Core : dotnet/aspnetcore#22656

@jennyf19
Copy link
Collaborator Author

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants