Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No deprecation warning/notice in the NPM registry for the deprecated passport-azure-ad Node module #2847

Closed
ethanherbertson opened this issue May 17, 2024 · 7 comments
Labels

Comments

@ethanherbertson
Copy link

ethanherbertson commented May 17, 2024

The default and only widely-used public registry for NodeJS packages, https://registry.npmjs.org/, does not currently flag the "passport-azure-ad" package as being deprecated, despite the deprecation notice published to the README of that project months ago, here: https://github.com/AzureAD/passport-azure-ad?tab=readme-ov-file#node-js-validation-replacement-for-passportjs.

This means that the many thousands of weekly installs of that module are not generating warnings visible to users that they are using unsupported/deprecated software.

Additionally, in the NPM registry's page for the package, the links to the project's repository and homepage are currently pointing to https://github.com/AzureAD/microsoft-authentication-library-for-js, which also does not contain a deprecation notice... and indeed does not obviously contain the project in question at all.

Instructions on how to properly deprecate Node packages are available here: https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions

(Apologies if this issue is being filed on the wrong repository. I was directed by the deprecation notice to a discussion on this project, so I assume this is where the ownership of this issue belongs.)

@jennyf19
Copy link
Collaborator

Thanks @ethanherbertson

@EmLauber Can you look into this one?

@EmLauber
Copy link

NPM is now appropriately updated to reflect that passport-azure-ad is deprecated.

@nwalters512
Copy link

nwalters512 commented May 31, 2024

It looks like this is the deprecation message:

Screenshot 2024-05-31 at 11 41 03

This is not very useful to me as a user as it doesn't tell me what I should replace the package with. Can you provide a better deprecation message to point me to the appropriate replacement package?

@ethanherbertson
Copy link
Author

@nwalters512 if you weren't aware, the latest info from the devs is that there is no recommended replacement yet.

@EmLauber Thank you for doing this! I would strongly recommend replacing the link to NPM support with a link to the deprecation message here: https://github.com/AzureAD/passport-azure-ad?tab=readme-ov-file#node-js-validation-replacement-for-passportjs

NPM support is really more for package maintainers, and your users would likely appreciate a breadcrumb towards the official explanation and discussion links.

@nwalters512
Copy link

if you weren't aware, the latest info from the devs is that there is no recommended replacement yet.

I'm unfortunately all too aware of this, with multiple large applications in production that rely on said deprecated package with no replacement 😢 truly insane behavior and decisions from Microsoft, but whatever. I just want the deprecation message to be upfront about the situation, instead of the generic "contact npm support" message that's currently there. Folks shouldn't have to hunt to find this important information.

@EmLauber
Copy link

EmLauber commented Jun 3, 2024

Thank you for your feedback. We have updated the depreciation message to link to https://github.com/AzureAD/passport-azure-ad?tab=readme-ov-file#node-js-validation-replacement-for-passportjs

@andrew-corliss
Copy link

@EmLauber - has there been any decision made from MS or can there be an update to the thread linked as to what developers should use instead for authenticating via MSAL or what a valid Passport strategy alternative is? There is no information on what should be the next steps?

side note in MS own documentation : https://learn.microsoft.com/en-us/azure/active-directory-b2c/enable-authentication-in-node-web-app-with-api is still pointing to use passport-azure-ad Can this be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants