Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Send minimal server side telemetry #327

Closed
jmprieur opened this issue Jul 16, 2020 · 3 comments
Closed

[Feature Request] Send minimal server side telemetry #327

jmprieur opened this issue Jul 16, 2020 · 3 comments
Assignees
Milestone

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Jul 16, 2020

Is your feature request related to a problem? Please describe.
Being able to send the sku (MsIdWeb) and version in requests to EVO so that we can measure the usage of Microsoft.Identity.Web and proactively contact 1P.

cc: @henrik-me

We want to know:

  • when MSAL makes a call is it initiated by Microsoft.Identity.Web ?
  • when Wilson makes a call, is it initiated by Microsoft.Identity.Web?

Today:

  • MSAL.NET will send x-client-sku: MSAL.NetCore (and x-client-ver the version)
  • ASP.NET Core will send x-client-sku: ID_NETSTANDARD2.0 (and x-client-ver the version)

We don't want to lose this information.

Therefore, given that Microsoft.Identity.Web acts as an orchestrator, the best is, as @jennyf19 suggested a few weeks ago, to add other properties in addition to the ones we have already.
x-client-orch: ID_WEB
x-client-orch-ver: (Microsoft.Identity.Web version from the assembly).

@jmprieur jmprieur added the enhancement New feature or request label Jul 16, 2020
@jmprieur jmprieur added this to the [3] Fundamentals milestone Jul 24, 2020
@jmprieur
Copy link
Collaborator Author

Warning: MSAL sku should not be changed (features are available based on SKU and version)

@jennyf19
Copy link
Collaborator

@jmprieur to clarify expectations here.

@jmprieur jmprieur self-assigned this Aug 28, 2020
@jmprieur jmprieur assigned jennyf19 and unassigned jmprieur Aug 31, 2020
@jmprieur jmprieur added Spec'd and removed spec'ing labels Aug 31, 2020
@jennyf19 jennyf19 modified the milestones: 0.4.0-preview, 0.4.1-preview Sep 9, 2020
@jmprieur
Copy link
Collaborator Author

Experiments done in the following branch: https://github.com/AzureAD/microsoft-identity-web/tree/jmprieur/experimentationsForSpecs

Marking this as blocked as:

  • we can change ID_NETSTANDARD_2 into ID_NETSTANDARD_2_IDWEB
  • but we cannot add-up IDWEB to the MSAL.NET sku.
    Henrik suggested using the telemetry blob, but they are for APIs, not for SKUs, and they would require surfacing something in the MSAL.NET API anyway, which I don't want to do
  • another possibility is to do pattern matching in Kusto, or even better, propagate the correlation ID. See [Feature Request] Expose requestID or correlation ID for requests made to AAD #494

@jmprieur jmprieur added blocked and removed Spec'd labels Sep 11, 2020
@jennyf19 jennyf19 removed the blocked label Sep 11, 2020
@jennyf19 jennyf19 added the fixed label Sep 14, 2020
@jmprieur jmprieur modified the milestones: 0.4.1-preview, GA version Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants