Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Reference Assembly does not have a strong name #682

Closed
1 of 8 tasks
cloudsere opened this issue Oct 15, 2020 · 10 comments
Closed
1 of 8 tasks

[Bug] Reference Assembly does not have a strong name #682

cloudsere opened this issue Oct 15, 2020 · 10 comments
Assignees
Milestone

Comments

@cloudsere
Copy link

Which version of Microsoft Identity Web are you using?
1.1.0

Where is the issue?
Referenced assembly 'Microsoft.Identity.Web.UI, Version=1.1.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
image

  • Web app
    • Sign-in users
    • Sign-in users and call web APIs
  • Web API
    • Protected web APIs (validating tokens)
    • Protected web APIs (validating scopes)
    • Protected web APIs call downstream web APIs
  • Token cache serialization
    • In-memory caches
    • Session caches
    • Distributed caches
  • Other (please describe)

Is this a new or an existing app?
This is a new app

Repro
Choose signing in solution properties
image

@jmprieur
Copy link
Collaborator

jmprieur commented Oct 15, 2020

@cloudsere where did you get the assembly from?

Did you build it yourself?
You probably did not get it from Nuget.org?
Our process imposes that the DLLs be signed by the release build, and I double-checked they were (but we verify at each release)

image

image

@jmprieur
Copy link
Collaborator

jmprieur commented Oct 15, 2020

Oh I see, sorry the strong name. I get it.
Microsoft.Identity.Web.UI does not have the <AssemblyOriginatorKeyFile>../../build/MSAL.snk</AssemblyOriginatorKeyFile> build property contrary to the other 3 assemblies

Thanks for the heads-up @cloudsere

@jmprieur jmprieur added bug Something isn't working P1 labels Oct 15, 2020
@jmprieur jmprieur added this to the 1.2.0 milestone Oct 15, 2020
@cloudsere
Copy link
Author

Very happy to see this is fixed, you guys are great! Just wondering when the 1.2.0 version will be released, will there be any preview version~? @jmprieur

@jmprieur
Copy link
Collaborator

@cloudsere : we intend to release at the end of this week.
Do you have an urgent need?

@cloudsere
Copy link
Author

I'm now working on the authentication part of my Web App, it is the basic of the whole app, so if there could be a preview version would be very helpful :) @jmprieur

@bgavrilMS
Copy link
Member

@cloudsere - as a workaround you could disable strong name validation on your dev box:

sn.exe -Vr *
from a Developer Command Prompt for VS201* (probably with Admin rights).

Note that strong naming is not a security feature, doesn't protect against code tampering, and many .NET projects don't even bother anymore. Code signing is the security feature.

@jmprieur
Copy link
Collaborator

Or just sn.exe -Vr for the DLL?

@bgavrilMS
Copy link
Member

Another workaround is to add a refrence to https://www.nuget.org/packages/StrongNamer/. We do this in unit tests, to overcome the fact that many .NET DLLs are not strong named.

@cloudsere
Copy link
Author

Will try both methods, thanks you guys @bgavrilMS @jmprieur ! Looking forward to 1.2.0 this week :)

@jennyf19
Copy link
Collaborator

@cloudsere Included in 1.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants