Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRK Levering v2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice, verwerking stand berichten #1596

Merged
merged 20 commits into from
Dec 27, 2022

Conversation

mprins
Copy link
Member

@mprins mprins commented Nov 22, 2022

Hiermee wordt het mogelijk BRK levering v2 (stand) berichten in de staging database te laden en te verwerken naar het nieuwe brk schema.

resolves:

  • BRMO-220 BRK 2 bericht definitie en xml reader met parser testcase en integratie test voor staging
  • BRMO-227 BRK2 directory scanner proces en bestanden laden via voorpagina
  • BRMO-225 BRK2 GDS2 ophalen proces
  • BRMO-229 brmo-proxyservice BRK 2 endpoint
  • BRMO-239 Introduceer database/schema switching voor bericht verwerking
  • BRMO-240 brmo_metadata tabel om versie info bij te houden
  • BRMO-221 BRK2 snapshot-to-rsgb XSL voor stand

Heeft #1473 nodig

@mprins mprins added this to the 4.0.0 milestone Nov 22, 2022
@mprins mprins self-assigned this Nov 22, 2022
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch 2 times, most recently from f4fed93 to a20f1d4 Compare November 22, 2022 17:33
@mprins mprins changed the title [BRMO-220] BRK 2 bericht definitie en xml reader WIP - [BRMO-220] BRK 2 bericht definitie en xml reader Nov 23, 2022
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch from 7263f02 to f9f1e75 Compare November 24, 2022 10:49
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1596 (3b3eeee) into master (f1b3e83) will decrease coverage by 1%.
The diff coverage is 39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #1596    +/-   ##
=========================================
- Coverage        36%     36%    -0%     
- Complexity      808     947   +139     
=========================================
  Files           410     414     +4     
  Lines         19317   19686   +369     
  Branches       1921    1963    +42     
=========================================
+ Hits           6876    7007   +131     
- Misses        11828   12054   +226     
- Partials        613     625    +12     
Impacted Files Coverage Δ
...ne/src/main/java/nl/b3p/brmo/commandline/Main.java 0% <0%> (ø)
...src/main/java/nl/b3p/brmo/service/jobs/NHRJob.java 0% <0%> (ø)
...brmo/service/scanner/AbstractExecutableProces.java 7% <0%> (-<1%) ⬇️
.../b3p/brmo/service/scanner/BAGDirectoryScanner.java 0% <0%> (ø)
...b3p/brmo/service/scanner/BRK2DirectoryScanner.java 0% <0%> (ø)
.../brmo/service/scanner/BerichtDoorsturenProces.java 0% <0%> (ø)
...service/scanner/BerichtTransformatieUitvoeren.java 0% <0%> (ø)
...b3p/brmo/service/scanner/BerichtstatusRapport.java 0% <0%> (ø)
...nl/b3p/brmo/service/scanner/GDS2OphalenProces.java 0% <0%> (ø)
.../brmo/service/scanner/LaadprocesStatusRapport.java 0% <0%> (ø)
... and 30 more

@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch from 06b27fa to 75c3804 Compare November 24, 2022 14:20
@mprins mprins changed the title WIP - [BRMO-220] BRK 2 bericht definitie en xml reader WIP - [BRMO-220][BRMO-227][BRMO-225] BRK 2 aanpassingen voor brmo-loader, brmo-service Nov 24, 2022
@mprins mprins changed the title WIP - [BRMO-220][BRMO-227][BRMO-225] BRK 2 aanpassingen voor brmo-loader, brmo-service WIP - [BRMO-220][BRMO-227][BRMO-225][BRMO-229] BRK 2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice Nov 24, 2022
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch from 4a6361e to 9644388 Compare December 1, 2022 10:43
@mprins mprins changed the title WIP - [BRMO-220][BRMO-227][BRMO-225][BRMO-229] BRK 2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice WIP - [BRMO-220][BRMO-221][BRMO-227][BRMO-225][BRMO-229] BRK 2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice Dec 2, 2022
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch 12 times, most recently from 055ba66 to 0f60bc3 Compare December 9, 2022 13:52
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch 4 times, most recently from 6216972 to 0344ddb Compare December 15, 2022 17:10
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch 3 times, most recently from 0794bfe to 846bf33 Compare December 27, 2022 09:52
@mprins mprins changed the title WIP - [BRMO-220][BRMO-221][BRMO-227][BRMO-225][BRMO-229] BRK 2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice BRK Levering v2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice Dec 27, 2022
rechten in (voorlopig?) juiste volgorde verwerken

tel stukdelen

fix geboorte en sterfdatum
fix VerwerkToevoegingMutatieIntegrationTest

geometrie laden
…dsplitsing welke soms niet in een bericht is opgenomen
* work around Jenkins message [Checks API] No suitable checks publisher found.

* update brmo-service testcases
@mprins mprins force-pushed the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch from 846bf33 to 3b3eeee Compare December 27, 2022 10:01
@mprins mprins marked this pull request as ready for review December 27, 2022 10:03
@B3Partners B3Partners deleted a comment from lgtm-com bot Dec 27, 2022
@mprins mprins changed the title BRK Levering v2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice BRK Levering v2 aanpassingen voor brmo-loader, brmo-service, brmo-proxyservice, verwerking stand berichten Dec 27, 2022
@mprins mprins merged commit 0e6aa2b into master Dec 27, 2022
@mprins mprins deleted the BRMO-220_BRMO-221_xsl_engine_en_brk2_bericht branch December 27, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant