[SUPPORT-13459] fix vb_verblijfsobject_adres voor Oracle
#1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprins
changed the title
vb_verblijfsobject_adres in oracle
mprins
requested changes
Feb 3, 2023
There was a problem hiding this comment.
Ik denk dat er iets scheef staat; de views worden niet aangemaakt.
Error: Failures:
Error: BAGViewsTest.testBasisViewsBAG:107 lijsten met basis views zijn ongelijk ==> expected: <[vb_adres, vb_adresseerbaar_object_geometrie, vb_ligplaats_adres, vb_standplaats_adres, vb_verblijfsobject_adres]> but was: <[vb_adres, vb_ligplaats_adres, vb_standplaats_adres]>
Error: MaterializedViewsTest.testBasisMViews:190 lijsten met materialized views zijn ongelijk ==> expected: <[mb_adres, mb_adres_bag, mb_adresseerbaar_object_geometrie_bag, mb_avg_koz_rechth, mb_avg_koz_rechth_bag, mb_avg_subject, mb_avg_zr_rechth, mb_ben_obj_nevenadres, mb_benoemd_obj_adres, mb_kad_onrrnd_zk_adres, mb_kad_onrrnd_zk_adres_bag, mb_kad_onrrnd_zk_archief, mb_koz_rechth, mb_koz_rechth_bag, mb_pand, mb_percelenkaart, mb_subject, mb_util_app_re_kad_perceel, mb_zr_rechth]> but was: <[mb_adres, mb_adres_bag, mb_avg_koz_rechth, mb_avg_subject, mb_avg_zr_rechth, mb_ben_obj_nevenadres, mb_benoemd_obj_adres, mb_kad_onrrnd_zk_adres, mb_kad_onrrnd_zk_archief, mb_koz_rechth, mb_pand, mb_percelenkaart, mb_subject, mb_util_app_re_kad_perceel, mb_zr_rechth]>
mprins
force-pushed
the
edit-208-bag2-oracle
branch
from
bba09fd to
a5cf188
Compare
mprins
requested changes
Feb 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
=========================================
- Coverage 37% 37% -0%
- Complexity 810 948 +138
=========================================
Files 414 414
Lines 21167 21167
Branches 2004 2004
=========================================
- Hits 7771 7770 -1
Misses 12774 12774
- Partials 622 623 +1
|
mprins
changed the title
vb_verblijfsobject_adres in oraclevb_verblijfsobject_adres voor Oracle
mprins
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Het attribuut 'maaktdeeluitvan' bevatte ook de gebruiksdoelen waar normaal gesproken het ID van het pand wordt opgeslagen. Door het script te vergelijken met het postgresql script, heb ik deze aanpassingen verricht. De aanleiding voor deze aanpassing was ticket SUPPORT-13459.