Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versie 2.1 van de views #617

Merged
merged 43 commits into from
Oct 20, 2019
Merged

versie 2.1 van de views #617

merged 43 commits into from
Oct 20, 2019

Conversation

cvanlith
Copy link
Contributor

@cvanlith cvanlith commented Feb 15, 2019

verwerking van al het commentaar tot zover, zie #615
mergen kan nog even wachten ivm mogelijk nieuw commentaar

  • postgresql versie
  • oracle versie
  • ms sqlserver versie
  • aanpassen van de gebruikte views in de brmo-soap module iig vb_util_app_re_kad_perceel in:
    resultNames.append(" gpa.perceel_identif as perceel_identif ");
    StringBuilder fromSQL = new StringBuilder(" vb_util_app_re_kad_perceel gpa ");
    StringBuilder whereSQL = new StringBuilder();
  • upgrade scripts + procedure voor de verschillende databases
    • postgis
    • oracle
    • sqlserver

lijst van de views

Omdat MS SQL Server geen ondersteuning voor materialized views heeft zijn er afwijkingen in de namen van de views. Onderstaande tabel geeft deze afwijkingen:

oracle postgresql sqlserver
mb_adres mb_adres vb_adres
mb_avg_koz_rechth mb_avg_koz_rechth vb_avg_koz_rechth
mb_avg_subject mb_avg_subject vb_avg_subject
mb_avg_zr_rechth mb_avg_zr_rechth vb_avg_zr_rechth
mb_ben_obj_nevenadres mb_ben_obj_nevenadres vb_ben_obj_nevenadres
mb_benoemd_obj_adres mb_benoemd_obj_adres vb_benoemd_obj_adres
mb_kad_onrrnd_zk_adres mb_kad_onrrnd_zk_adres vb_kad_onrrnd_zk_adres
mb_kad_onrrnd_zk_archief mb_kad_onrrnd_zk_archief vb_kad_onrrnd_zk_archief
mb_koz_rechth mb_koz_rechth vb_koz_rechth
vb_ligplaats_adres vb_ligplaats_adres vb_ligplaats_adres
mb_pand mb_pand vb_pand
vb_standplaats_adres vb_standplaats_adres vb_standplaats_adres
mb_subject mb_subject vb_subject
mb_util_app_re_kad_perceel mb_util_app_re_kad_perceel vb_util_app_re_kad_perceel
vb_util_app_re_parent vb_util_app_re_parent vb_util_app_re_parent
vb_util_app_re_parent_2 vb_util_app_re_parent_2 vb_util_app_re_parent_2
vb_util_app_re_parent_3 vb_util_app_re_parent_3 vb_util_app_re_parent_3
vb_util_app_re_splitsing vb_util_app_re_splitsing vb_util_app_re_splitsing
vb_util_zk_recht vb_util_zk_recht vb_util_zk_recht
vb_vbo_adres vb_vbo_adres vb_vbo_adres
mb_zr_rechth mb_zr_rechth vb_zr_rechth
mb_percelenkaart mb_percelenkaart vb_percelenkaart

@mprins mprins changed the title versie 2.1 van de views [WIP] versie 2.1 van de views Apr 2, 2019
@mprins mprins added this to the Future milestone Apr 2, 2019
@mprins
Copy link
Member

mprins commented Apr 2, 2019

Opmerkingen van GertJan:
20190328_BRMO_refresh_mview_mb_benoemd_obj_adres_v1.0.pdf

zie ook mantis 13390

@mprins mprins modified the milestones: Future, 2.0.0 Sep 3, 2019
@mprins mprins self-requested a review September 3, 2019 11:25
@mprins mprins changed the title [WIP] versie 2.1 van de views versie 2.1 van de views Sep 27, 2019
@mprins mprins self-assigned this Sep 27, 2019
@mprins

This comment has been minimized.

@mprins mprins force-pushed the basisviews_v2_1 branch 2 times, most recently from da08346 to 71d9318 Compare October 3, 2019 16:57
@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #617 into master will increase coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #617      +/-   ##
============================================
+ Coverage      30.7%   31.08%   +0.37%     
  Complexity      805      805              
============================================
  Files           319      319              
  Lines         14970    14929      -41     
  Branches       1440     1419      -21     
============================================
+ Hits           4597     4641      +44     
+ Misses         9947     9850      -97     
- Partials        426      438      +12
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/nl/b3p/brmo/soap/db/EigendomInfo.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ader/gml/light/GMLLightFeatureTransformerImpl.java 78.43% <0%> (-10.79%) 0% <0%> (ø)
...n/java/nl/b3p/brmo/bgt/util/JDBCDataStoreUtil.java 34.61% <0%> (-3.85%) 0% <0%> (ø)
...o/service/stripes/AdvancedFunctionsActionBean.java 25.64% <0%> (-0.65%) 0% <0%> (ø)
...java/nl/b3p/brmo/loader/gml/BGTGMLLightLoader.java 62.23% <0%> (-0.35%) 0% <0%> (ø)
...er/src/main/java/nl/b3p/brmo/loader/RsgbProxy.java 75.13% <0%> (-0.12%) 0% <0%> (ø)
...src/main/java/nl/b3p/brmo/loader/StagingProxy.java 61.78% <0%> (+0.2%) 0% <0%> (ø) ⬇️
...rc/main/java/nl/b3p/brmo/loader/BrmoFramework.java 42.74% <0%> (+5.09%) 0% <0%> (ø) ⬇️
.../nl/b3p/brmo/loader/util/TopNLRsgbTransformer.java 65.95% <0%> (+65.95%) 0% <0%> (ø) ⬇️
...n/java/nl/b3p/brmo/loader/xml/TopNLFileReader.java 76.19% <0%> (+76.19%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8b03d...bcda6eb. Read the comment docs.

@mprins

This comment has been minimized.

[oracle] afbreken na fout tijdelijk uit tot na 2.0.0 release
[slqserver] gebruik if exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants